[Buildroot] [PATCH v2 1/1] package/php-xdebug: new package

[Nicolas Carrier]

Hello,
I tried to address all your comments, but:
 * I didn't manage to use test-pkg, I ran:
       ./utils/test-pkg -p php-xdebug -c php-xdebug.config
   but only got a bunch of [...] SKIPPED messages
   (same with -a).
   php-xdebug.config's content was:
       BR2_PACKAGE_PHP_XDEBUG=y
 * I didn't manage either to use check-package. I ran:
       $ ./utils/check-package package/php-xdebug/*
   _before_ fixing the two errors Arnout mentioned in the Config.in,
   but just got:
       36 lines processed
       0 warnings generated

I bet I'm doing things wrong, but couldn't figure out how ^^


Anyway, I fixed all, I think, then tested that the php-xdebug extension
could be loaded and called one of its functions in one of our product
using php's CLI.
I also ran a test build with a qemu defconfig (x86_amd64 if I'm
correct) and the build went fine too.

On Wed, 2019-09-25 at 13:45 +0200, Nicolas Carrier wrote:
> Extension for PHP to assist with debugging and development.
> 
> Signed-off-by: Nicolas Carrier <nicolas.carrier at orolia.com>
> ---
> 
> Changes v1 -> v2:
>   - move xdebug to php extensions submenu, with the following two
> consequences:
>         - makes it dependent on php
>         - makes it wrapped inside !STATIC test
>   - removed empty line in Config.in
>   - removed Web page: prefix in help string
>   - one option per line in PHP_XDEBUG_CONF_OPTS
>   - renamed to php-xdebug
>   - changed license to `Xdebug License (PHP-3.0-like)`
> 
> 
>  package/Config.in                  |  1 +
>  package/php-xdebug/Config.in       |  6 ++++++
>  package/php-xdebug/php-xdebug.hash |  3 +++
>  package/php-xdebug/php-xdebug.mk   | 27 +++++++++++++++++++++++++++
>  4 files changed, 37 insertions(+)
>  create mode 100644 package/php-xdebug/Config.in
>  create mode 100644 package/php-xdebug/php-xdebug.hash
>  create mode 100644 package/php-xdebug/php-xdebug.mk
> 
> diff --git a/package/Config.in b/package/Config.in
> index 10b441c6e1..1ddc82644f 100644
> --- a/package/Config.in
> +++ b/package/Config.in
> @@ -801,6 +801,7 @@ menu "External php extensions"
>  	source "package/php-memcached/Config.in"
>  	source "package/php-ssh2/Config.in"
>  	source "package/php-yaml/Config.in"
> +	source "package/php-xdebug/Config.in"
>  	source "package/php-zmq/Config.in"
>  endmenu
>  endif
> diff --git a/package/php-xdebug/Config.in b/package/php-
> xdebug/Config.in
> new file mode 100644
> index 0000000000..b5919e06cd
> --- /dev/null
> +++ b/package/php-xdebug/Config.in
> @@ -0,0 +1,6 @@
> +config BR2_PACKAGE_PHP_XDEBUG
> +	bool "php-xdebug"
> +	help
> +	  Extension for PHP to assist with debugging and development.
> +
> +	  http://xdebug.org
> diff --git a/package/php-xdebug/php-xdebug.hash b/package/php-
> xdebug/php-xdebug.hash
> new file mode 100644
> index 0000000000..d645142efc
> --- /dev/null
> +++ b/package/php-xdebug/php-xdebug.hash
> @@ -0,0 +1,3 @@
> +# Locally computed
> +sha256
> ef479ee1a3da3f933e0d046ca8cd0c14601f29b2c0c41cc60c9388546a4e0272  LIC
> ENSE
> +sha256
> b2aeb55335c5649034fe936abb90f61df175c4f0a0f0b97a219b3559541edfbd  php
> -xdebug-2.7.2.tar.gz
> diff --git a/package/php-xdebug/php-xdebug.mk b/package/php-
> xdebug/php-xdebug.mk
> new file mode 100644
> index 0000000000..d63bc9f8ce
> --- /dev/null
> +++ b/package/php-xdebug/php-xdebug.mk
> @@ -0,0 +1,27 @@
> +####################################################################
> ############
> +#
> +# php-xdebug
> +#
> +####################################################################
> ############
> +
> +PHP_XDEBUG_VERSION = 2.7.2
> +PHP_XDEBUG_SITE = $(call github,xdebug,xdebug,$(PHP_XDEBUG_VERSION))
> +PHP_XDEBUG_INSTALL_STAGING = YES
> +PHP_XDEBUG_LICENSE = Xdebug License (PHP-3.0-like)
> +PHP_XDEBUG_LICENSE_FILES = LICENSE
> +PHP_XDEBUG_DEPENDENCIES = php host-autoconf
> +PHP_XDEBUG_CONF_OPTS = \
> +	--enable-xdebug \
> +	--with-php-config=$(STAGING_DIR)/usr/bin/php-config \
> +	--with-xdebug=$(STAGING_DIR)/usr
> +
> +define PHP_XDEBUG_PHPIZE
> +	(cd $(@D); \
> +		PHP_AUTOCONF=$(HOST_DIR)/usr/bin/autoconf \
> +		PHP_AUTOHEADER=$(HOST_DIR)/usr/bin/autoheader \
> +		$(STAGING_DIR)/usr/bin/phpize)
> +endef
> +
> +PHP_XDEBUG_PRE_CONFIGURE_HOOKS += PHP_XDEBUG_PHPIZE
> +
> +$(eval $(autotools-package))