[Buildroot] [PATCH 2/2] package/znc: switch to cmake

[Thomas Petazzoni]

On Sat, 28 Sep 2019 12:41:06 +0200
Bernd Kuhls <bernd.kuhls at t-online.de> wrote:

> Upstream deprecated autoconf and asks to use cmake:
> https://github.com/znc/znc/commit/71f35b003dda65f3867ff84deaf8aa15bcd0b958
> 
> Add options to explicitly disable cyrus and i18n support.
> 
> Signed-off-by: Bernd Kuhls <bernd.kuhls at t-online.de>
> ---
>  package/znc/znc.mk | 22 ++++++++++++----------
>  1 file changed, 12 insertions(+), 10 deletions(-)

Applied to master, thanks. Regarding the WANT_I18N option, what does it
do exactly ? Indeed, the autotools package infrastructure was
automatically passing --enable-nls or --disable-nls depending on the
value of BR2_SYSTEM_ENABLE_NLS. So with your unconditional addition of
WANT_I18N=OFF, I'm wondering if we have lost NLS support in znc when
BR2_SYSTEM_ENABLE_NLS=y. Could you check this ?

Thanks,

Thomas
-- 
Thomas Petazzoni, CTO, Bootlin
Embedded Linux and Kernel engineering
https://bootlin.com