[Buildroot] [PATCH v2 3/3] packageJopenjdk: add support for building the full jdk

[Ryan Barnett]

Adam,

Thank you for posting this series of patches. Below is some minor feedback:

Title has a misspelling:

s:packageJopenjd:package/openjdk:

On Sat, Apr 18, 2020 at 2:12 PM <aduskett at gmail.com> wrote:
>
> From: Adam Duskett <Aduskett at gmail.com>
>
> Some users may require the full JDK on the target to debug their programs.
> This change is relatively trivial to add.
>
> While the full JDK does have programs used for compiling on a target,
> which is against Buildroot policy, the JDK also has several utilities used for
> debugging purposes, which the JRE target does not build, and Buildroot supports
> applications used for debugging purposes such as GDB.
>
> As such, JDK support should be available for debugging purposes, and a note in
> the Config.in file has been added under the JDK section, which informs the user
> that JDK support is for debugging purposes only and that developing on a
> target is not supported by Buildroot.
>
> Signed-off-by: Adam Duskett <Aduskett at gmail.com>
> ---
> Changes v1 -> v2:
>   - Added a much more thurough commit message as to why the JDK may be useful.

s/thurough/through/

>   - Added a note in the Config.in file explaining that full JDK support is
>     only for debugging purposes.
>   - Added a target_finalize_hook which removes the include and demo directory
>     from the target.
>
>  package/openjdk/Config.in  | 54 ++++++++++++++++++++++++++++++++++++++
>  package/openjdk/openjdk.mk | 21 +++++++++++++--
>  2 files changed, 73 insertions(+), 2 deletions(-)

Reviewed-by: Ryan Barnett <ryan.barnett at rockwellcollins.com>
Tested-by: Ryan Barnett <ryan.barnett at rockwellcollins.com>

Built and runtime tested on x86-64 platform.

Thanks,
-Ryan