[Buildroot] [PATCHv2 03/12] configs/amarula_a64_relic_defconfig: remove BR2_PACKAGE_HOST_ANDROID_TOOLS_FASTBOOT

Romain Naour romain.naour at gmail.com
Tue Apr 21 19:48:23 UTC 2020


Hi Thomas,

Le 21/04/2020 à 21:43, Thomas Petazzoni a écrit :
> On Tue, 21 Apr 2020 19:26:37 +0200
> Romain Naour <romain.naour at gmail.com> wrote:
> 
>> This option is lost while loading the defconfig with:
>> make amarula_a64_relic_defconfig
>>
>> This fixes the new defconfig check.
>>
>> Signed-off-by: Romain Naour <romain.naour at gmail.com>
>> Cc: Jagan Teki <jagan at amarulasolutions.com>
>> ---

>> If android tools is really required for this defconfig,
>> BR2_PACKAGE_HOST_ANDROID_TOOLS must be selected first.
(*)

>> ---
>>  configs/amarula_a64_relic_defconfig | 1 -
>>  1 file changed, 1 deletion(-)
>>
>> diff --git a/configs/amarula_a64_relic_defconfig b/configs/amarula_a64_relic_defconfig
>> index f2e7e7f965..5a62fbf6c4 100644
>> --- a/configs/amarula_a64_relic_defconfig
>> +++ b/configs/amarula_a64_relic_defconfig
>> @@ -40,7 +40,6 @@ BR2_LINUX_KERNEL_NEEDS_HOST_OPENSSL=y
>>  BR2_TARGET_GENERIC_ISSUE="Welcome to Amarula A64-Relic"
>>  BR2_TARGET_ROOTFS_EXT2=y
>>  BR2_TARGET_ROOTFS_EXT2_4=y
>> -BR2_PACKAGE_HOST_ANDROID_TOOLS_FASTBOOT=y
> 
> The intention is to have android-tools for the host enabled, because
> board/amarula/a64-relic/readme.txt makes use of fastboot to reflash the
> board.
> 
> So the proper fix is to add:
> 
> BR2_PACKAGE_HOST_ANDROID_TOOLS=y
> 
> and of course adjust the commit log accordingly. No need to resend the
> whole series for that, we can fix when applying.

Thanks for the review, I was not 100% sure, see (*).

Best regards,
Romain


> 
> Best regards,
> 
> Thomas
> 




More information about the buildroot mailing list