[Buildroot] [PATCH 1/1] package/pkg-meson.mk: set correct pkgconfig for native dependencies

[James Hilliard]

On Tue, Apr 28, 2020 at 12:50 AM Arnout Vandecappelle <arnout at mind.be> wrote:
>
>
>
> On 28/04/2020 07:22, Thomas Petazzoni wrote:
> > +++ b/package/pkg-meson.mk
> > @@ -87,6 +87,7 @@ define $(2)_CONFIGURE_CMDS
> >               --default-library=$(if $(BR2_STATIC_LIBS),static,shared) \
> >               --buildtype=$(if $(BR2_ENABLE_DEBUG),debug,release) \
> >               --cross-file=$$($$(PKG)_SRCDIR)/build/cross-compilation.conf \
> > +             -Dbuild.pkg_config_path=$$(HOST_DIR)/lib/pkgconfig \
>
>  This can't be right. Here you're setting the pkg_config_path to the one for
> native build. It may work in the specific case of wayland-scanner where you
> actually want the native one, but it will break anything that requires the cross
> package config.
We've essentially already been using this exact option for weston so I'm pretty
sure it's correct. This option should only override pkgconfig for native: true
dependencies.
>
>  (Of course, this statement is just from reading the code, I could be wrong.)
>
>  Regards,
>  Arnout
>
> >               $$($$(PKG)_CONF_OPTS) \
> >               $$($$(PKG)_SRCDIR) $$($$(PKG)_SRCDIR)/build