[Buildroot] [PATCH] package/mg: new package

Joachim Nilsson troglobit at gmail.com
Mon Aug 31 19:53:22 UTC 2020


On Sun Aug 30, 2020 at 10:06 PM CEST, Thomas Petazzoni wrote:
> Thanks for your contribution!

Thanks, and thank you for the review!

> On Sun, 30 Aug 2020 11:00:51 +0200 Joachim Wiberg <troglobit at gmail.com> wrote:
> > +# From https://sourceforge.net/projects/joe-editor/files/JOE%20sources/joe-4.6/
> Is this a bad copy paste ?

Indeed.

> > +# mg2a
> Should be just "mg"

OK, fixing

> > +ifeq ($(BR2_PACKAGE_NCURSES),y)
> > +MG_DEPENDENCIES += ncurses
> Could you add:
> MG_CONF_OPTS += --with-curses
> or whatever is needed to explicitly enable ncurses support ?

It's auto-detected, but will do.

> > +define MG_INSTALL_TARGET_CMDS
> > +	$(INSTALL) -m 0755 -D $(@D)/tutorial $(TARGET_DIR)/usr/share/doc/tutorial
> > +	gzip -9 $(TARGET_DIR)/usr/share/doc/tutorial
> /usr/share/doc gets dropped from $(TARGET_DIR) during the
> target-finalize step, so installing documentation there is not useful.

Yeah I realized.  It's actually referenced from withing Mg using C-h t,
should that be patched out then?

Best regards
 /Joachim




More information about the buildroot mailing list