[Buildroot] [PATCH] package/go: fix a typo in CC and CXX env values

Yann E. MORIN yann.morin.1998 at free.fr
Sat Dec 19 11:11:46 UTC 2020


Michael, All,

On 2020-12-18 09:57 +0000, Michael Baudino spake thusly:
> This commit fixes a typo in variable names that caused CC and CXX
> environment variables to be empty.
> 
> Signed-off-by: Michael Baudino <michael at baudi.no>

Applied to master, thanks.

However, see a little comment, below...

> ---
>  package/go/go.mk | 4 ++--
>  1 file changed, 2 insertions(+), 2 deletions(-)
> 
> diff --git package/go/go.mk package/go/go.mk
> index d9f4905..cabbdc8 100644
> --- package/go/go.mk
> +++ package/go/go.mk

I'm not sure how you generated your patch, but this does not apply as-is
because it is not the expected depth, so git-am chokes on it.

Next time, please use 'git send-email' to send your patches, as it
ensures that patches are properly formatted.

I fixed it locally (and will do so on your next patch too), so no need
to resend those two.

Regards,
Yann E. MORIN.

> @@ -99,8 +99,8 @@ HOST_GO_HOST_ENV = \
>  	$(HOST_GO_COMMON_ENV) \
>  	GOARCH="" \
>  	GOCACHE="$(HOST_GO_HOST_CACHE)" \
> -	CC="$(HOST_CCNOCCACHE)" \
> -	CXX="$(HOST_CXXNOCCACHE)" \
> +	CC="$(HOSTCC_NOCCACHE)" \
> +	CXX="$(HOSTCXX_NOCCACHE)" \
>  	CGO_CFLAGS="$(HOST_CFLAGS)" \
>  	CGO_CXXFLAGS="$(HOST_CXXFLAGS)" \
>  	CGO_LDFLAGS="$(HOST_LDFLAGS)"
> --
> 2.7.4
> _______________________________________________
> buildroot mailing list
> buildroot at busybox.net
> http://lists.busybox.net/mailman/listinfo/buildroot

-- 
.-----------------.--------------------.------------------.--------------------.
|  Yann E. MORIN  | Real-Time Embedded | /"\ ASCII RIBBON | Erics' conspiracy: |
| +33 662 376 056 | Software  Designer | \ / CAMPAIGN     |  ___               |
| +33 561 099 427 `------------.-------:  X  AGAINST      |  \e/  There is no  |
| http://ymorin.is-a-geek.org/ | _/*\_ | / \ HTML MAIL    |   v   conspiracy.  |
'------------------------------^-------^------------------^--------------------'



More information about the buildroot mailing list