[Buildroot] [PATCH] infra: don't be verbose when calling the instrumentation steps
Yann E. MORIN
yann.morin.1998 at free.fr
Sat Feb 22 11:05:41 UTC 2020
Thomas, All,
On 2020-02-22 11:59 +0100, Thomas De Schampheleire spake thusly:
> On Sat, Feb 22, 2020, 11:38 Yann E. MORIN < [1]yann.morin.1998 at free.fr> wrote:
>
> Commit 509db3b88a added calls to (parts of) the instrumentation steps.
> However, those calls are echoed, unlike the other places where we call
> them (in the package infra).
>
> Signed-off-by: Yann E. MORIN < [2]yann.morin.1998 at free.fr>
> Cc: Thomas De Schampheleire < [3]patrickdepinguin at gmail.com>
> ---
> Makefile | 12 ++++++------
> 1 file changed, 6 insertions(+), 6 deletions(-)
>
> diff --git a/Makefile b/Makefile
> index 9662987bb4..b61a20a354 100644
> --- a/Makefile
> +++ b/Makefile
> @@ -807,12 +807,12 @@ endif # merged /usr
> # AFTER ALL FILE-CHANGING ACTIONS:
> # Update timestamps in internal file list to fix attribution of files
> # to packages on subsequent builds
> - $(call step_pkg_size_file_list,$(TARGET_DIR))
> - $(call step_pkg_size_finalize)
> - $(call step_pkg_size_file_list,$(STAGING_DIR),-staging)
> - $(call step_pkg_size_finalize,-staging)
> - $(call step_pkg_size_file_list,$(HOST_DIR),-host)
> - $(call step_pkg_size_finalize,-host)
> + @$(call step_pkg_size_file_list,$(TARGET_DIR))
> + @$(call step_pkg_size_finalize)
> + @$(call step_pkg_size_file_list,$(STAGING_DIR),-staging)
> + @$(call step_pkg_size_finalize,-staging)
> + @$(call step_pkg_size_file_list,$(HOST_DIR),-host)
> + @$(call step_pkg_size_finalize,-host)
>
> Perhaps this should rather be $(Q) than @?
We're using @ in all other places where we call the hooks, and this
patch is just doing the same here. If we want $(Q) here (which I think
is a good idea), we'd want to *also* change the existing calls to steps
in the package infra at the same time.
I just want to have a minimalist patch here, that aligns the very recent
changes to the long-existing code.
> I quite like the fact that you can see what's going on, mostly relevant
> when investigating an issue...
Yes, I do agree.
Care to send a patch afterwards, that changes the existing code? ;-)
Regards,
Yann E. MORIN.
--
.-----------------.--------------------.------------------.--------------------.
| Yann E. MORIN | Real-Time Embedded | /"\ ASCII RIBBON | Erics' conspiracy: |
| +33 662 376 056 | Software Designer | \ / CAMPAIGN | ___ |
| +33 561 099 427 `------------.-------: X AGAINST | \e/ There is no |
| http://ymorin.is-a-geek.org/ | _/*\_ | / \ HTML MAIL | v conspiracy. |
'------------------------------^-------^------------------^--------------------'
More information about the buildroot
mailing list