[Buildroot] [PATCH 2/2] package/git: fix build failure due to gcc bug 93847

Peter Korsgaard peter at korsgaard.com
Thu Feb 27 21:42:31 UTC 2020


>>>>> "Yann" == Yann E MORIN <yann.morin.1998 at free.fr> writes:

Hi,

 >> This fails for a (hypothetical) toolchain affected by both issues,
 >> perhaps something like this would be better?
 >> 
 >> ifneq ($(BR2_TOOLCHAIN_HAS_GCC_BUG_85180)$(BR2_TOOLCHAIN_HAS_GCC_BUG_93847),)

 > Or we can keep positive logic and use the available make utilities:

 >     ifeq ($(or $(BR2_TOOLCHAIN_HAS_GCC_BUG_85180),$(BR2_TOOLCHAIN_HAS_GCC_BUG_93847)),y)

We could, but I already applied the change and we use similar logic in a
number of places:

package/armbian-firmware/armbian-firmware.mk:ifneq ($(ARMBIAN_FIRMWARE_FILES)$(ARMBIAN_FIRMWARE_DIRS),)
package/avahi/avahi.mk:ifneq ($(BR2_PACKAGE_AVAHI_DAEMON)$(BR2_PACKAGE_AVAHI_AUTOIPD),)
package/freerdp/freerdp.mk:ifneq ($(BR2_PACKAGE_FREERDP_CLIENT_X11)$(BR2_PACKAGE_FREERDP_CLIENT_WL),)

-- 
Bye, Peter Korsgaard



More information about the buildroot mailing list