[Buildroot] [RFC PATCH] autotools: do not overwrite first include path

[Heiko Thiery]

Hi All,

Am Do., 12. Dez. 2019 um 11:08 Uhr schrieb Heiko Thiery
<heiko.thiery at gmail.com>:
>
> Hi,
>
> On 12/12/19 9:57 AM, Michael Walle wrote:
> > The first include path is special in aclocal. For example it is the path
> > for the --install option. Also, the first include is treated in a
> > special way if it doesn't exists. This might be the case if there is the
> > following construct:
> >
> >    configure.ac: AC_CONFIG_MACRO_DIR([m4])
> >    Makefile.am: ACLOCAL_AMFLAGS="-I m4"
> >
> > If the package doesn't have local macros, the m4/ directory might not
> > exist. aclocal will then just issue a warning instead of aborting the
> > execution with a fatal error. See discussion here:
> >    https://bugs.debian.org/cgi-bin/bugreport.cgi?bug=565663
> >
> > Don't use the "-I" option in aclocal. Instead use ACLOCAL_PATH to pass
> > the system-wide include dirs.
> >
> > As a side effect this should fix the use of $(ACLOCAL) alone. Up until
> > now, $(ACLOCAL) didn't include the ACLOCAL_HOST_DIR system include path.
> >
> > autoreconf will pass the "-I" options to every tool it runs. So move the
> > argument to each individual tool except aclocal.
> >
> > Signed-off-by: Michael Walle <michael at walle.cc>
> > Signed-off-by: Heiko Thiery <heiko.thiery at gmail.com>
>
> I made a test by removing the $(pkg)_POST_PATCH_HOOKS for the following
> packages:
>
> - atest
> - davici
> - libscsi
> - ltrace
> - minicom
> - open-lldp
> - openpgm
> - pdbg
>
> The result is that all this packages still build without this hook.
>
> --
> Heiko

Has anyone the time to take a look on it and give a comment?

BR
Heiko