[Buildroot] [PATCH 1/1] package/wpa_supplicant: disable TEAP for internal TLS implementation

Arnout Vandecappelle arnout at mind.be
Mon Jan 13 23:05:53 UTC 2020



On 08/01/2020 20:04, Sergey Matyukevich wrote:
> EAP-TEAP support in hostapd/wpa_supplicant fails to build with internal
> TLS implementation. This patch disables TEAP support in wpa_supplicant
> when internal TLS implementation is selected. Similar fix for hostapd
> package has already been merged to Buildroot: see commit 47d14e3b1c20
> ("package/hostapd: disable TEAP for internal TLS implementation").
> 
> TEAP is still an experimental feature that is not recommmended for
> production use. Currently it should not be used for anything else
> than experimentation and interoperability testing. Those who needs
> experimenting with TEAP are encouraged to enable openssl in their
> buildroot configuration.

 So then why don't we just unconditionally disable this feature? Preferably with
a comment in the .mk file that it's disabled due to its experimental nature, so
that someone who needs it a couple of years down the line can note that it's not
longer experimental.

 Regards,
 Arnout

> 
> Fixes:
> http://autobuild.buildroot.net/results/e83613c06041a60f89da787f4ebf876245713cd2/
> 
> Signed-off-by: Sergey Matyukevich <geomatsi at gmail.com>
> ---
>  package/wpa_supplicant/wpa_supplicant.mk | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
> 
> diff --git a/package/wpa_supplicant/wpa_supplicant.mk b/package/wpa_supplicant/wpa_supplicant.mk
> index 4f95ea6276..c87494c2bf 100644
> --- a/package/wpa_supplicant/wpa_supplicant.mk
> +++ b/package/wpa_supplicant/wpa_supplicant.mk
> @@ -112,7 +112,7 @@ WPA_SUPPLICANT_DEPENDENCIES += host-pkgconf libopenssl
>  WPA_SUPPLICANT_LIBS += `$(PKG_CONFIG_HOST_BINARY) --libs openssl`
>  WPA_SUPPLICANT_CONFIG_EDITS += 's/\#\(CONFIG_TLS=openssl\)/\1/'
>  else
> -WPA_SUPPLICANT_CONFIG_DISABLE += CONFIG_EAP_PWD
> +WPA_SUPPLICANT_CONFIG_DISABLE += CONFIG_EAP_PWD CONFIG_EAP_TEAP
>  WPA_SUPPLICANT_CONFIG_EDITS += 's/\#\(CONFIG_TLS=\).*/\1internal/'
>  endif
>  
> 



More information about the buildroot mailing list