[Buildroot] [PATCH v3 7/9] package/efl: depend on lua ABI version 5.1
James Hilliard
james.hilliard1 at gmail.com
Mon Jul 27 19:23:24 UTC 2020
On Mon, Jul 27, 2020 at 1:19 PM Yann E. MORIN <yann.morin.1998 at free.fr> wrote:
>
> James, All,
>
> On 2020-05-24 18:48 -0600, James Hilliard spake thusly:
> > Since efl is compatible with lua interpreters that provide the
> > version 5.1 ABI we should depend on that instead of unconditionally
> > selecting luajit.
> >
> > Signed-off-by: James Hilliard <james.hilliard1 at gmail.com>
> > ---
> [--SNIP--]
> > @@ -379,6 +385,14 @@ else
> > HOST_EFL_CONF_OPTS += --disable-cxx-bindings
> > endif
> >
> > +ifeq ($(BR2_PACKAGE_LUAJIT),y)
> > +HOST_EFL_CONF_OPTS += --disable-lua-old
> > +HOST_EFL_DEPENDENCIES += host-luajit
> > +else ifeq ($(BR2_PACKAGE_LUA),y)
> > +HOST_EFL_CONF_OPTS += --enable-lua-old
> > +HOST_EFL_DEPENDENCIES += host-lua
> > +endif
>
> Why does the host variant need to build against the same as the target
> variant?
I think we can change that to just depend on host-luainterpreter which should
select the right version.
>
> It is very unusual that a target option (here, the target Lua
> interpreter) drives the compilation and dependencies of a host package,
> so this warrants a bit of explanations.
>
> Regards,
> Yann E. MORIN.
>
> --
> .-----------------.--------------------.------------------.--------------------.
> | Yann E. MORIN | Real-Time Embedded | /"\ ASCII RIBBON | Erics' conspiracy: |
> | +33 662 376 056 | Software Designer | \ / CAMPAIGN | ___ |
> | +33 561 099 427 `------------.-------: X AGAINST | \e/ There is no |
> | http://ymorin.is-a-geek.org/ | _/*\_ | / \ HTML MAIL | v conspiracy. |
> '------------------------------^-------^------------------^--------------------'
More information about the buildroot
mailing list