[Buildroot] [PATCH] package/prosody: fix dependency

François Perrad francois.perrad at gadz.org
Wed Jul 29 13:01:00 UTC 2020


Le mar. 28 juil. 2020 à 22:25, Yann E. MORIN <yann.morin.1998 at free.fr> a
écrit :

> François, All,
>
> On 2020-07-28 11:21 +0200, François Perrad spake thusly:
> > Le mar. 28 juil. 2020 à 09:21, Thomas Petazzoni < [1]
> thomas.petazzoni at bootlin.com> a écrit :
> >   > LuaBitOp is not available with Lua 5.3
> >   The commit log is probably not very clear. Indeed, if LuaBitOp is not
> >   available with Lua 5.3, one would think you would need the external
> >   BR2_PACKAGE_LUABITOP when using something else than 5.1, i.e the
> >   opposite of what your change is doing.
> >
> >   Shouldn't the commit log rather be:
> >
> >     The luabitop functionality is available built-in in Lua 5.3 and
> >     LuaJIT, so only Lua 5.1 needs the additional external luabitop
> >     package.
> >
> >   Could you confirm ?
> >
> > bitwise operators are built-in in Lua 5.3,
> > LuaBitOp is a built-in library in LuaJIT,
> > so only Lua 5.1 needs the additional external LuaBitOp package.
>
> OK, thanks for the explanations.
>
> However, luabitop depends on !lua-5.3, and I see in your latest series
> that you extended the dependency to !lua-5.4. Maybe we should also
> fix that, no?
>
> That is, we should have:
>
>     config BR2_PACKAGE_LUABITOP
>         depends on BR2_PACKAGE_LUA_5_1
>
>
Correct.


> However, you are saying (emphasize mine):
>
>     "only Lua 5.1 **needs** the additional external LuaBitOp"
>
> Does that mean that it can still be used with other versions of Lua?
>
> That is, if we are using lua-5.3, and a package selects luabitop, will
> this fail to build? To run? In other words, is it a problem if a pacakge
> ends up using luabitop on another version of lua?
>
>
LuaBitOp fails to build with Lua 5.3 & 5.4.
LuaBitOp could be built with :
- Lua 5.1
- Lua 5.2 which is now retired of BR
- LuaJIT which uses ABI 5.1, but useless (because already built-in)

François

Regards,
> Yann E. MORIN.
>
> --
>
> .-----------------.--------------------.------------------.--------------------.
> |  Yann E. MORIN  | Real-Time Embedded | /"\ ASCII RIBBON | Erics'
> conspiracy: |
> | +33 662 376 056 | Software  Designer | \ / CAMPAIGN     |  ___
>      |
> | +33 561 099 427 `------------.-------:  X  AGAINST      |  \e/  There is
> no  |
> | http://ymorin.is-a-geek.org/ | _/*\_ | / \ HTML MAIL    |   v
>  conspiracy.  |
>
> '------------------------------^-------^------------------^--------------------'
>
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.busybox.net/pipermail/buildroot/attachments/20200729/91089045/attachment-0002.html>


More information about the buildroot mailing list