[Buildroot] [PATCH v6 14/28] package/qt5webengine: Convert to qmake infra

Thomas Petazzoni thomas.petazzoni at bootlin.com
Wed Mar 11 22:01:37 UTC 2020


Hello,

On Mon, 17 Feb 2020 22:23:36 +0100
Andreas Naumann <anaumann at ultratronik.de> wrote:

> Mostly straightforward conversion but keeping custom config/build env
> to apply the python2 workaround.
> 
> Signed-off-by: Andreas Naumann <anaumann at ultratronik.de>

I've applied, but I have a comment, see below.

> +QT5WEBENGINE_CONF_ENV = $(QT5WEBENGINE_ENV)
> +QT5WEBENGINE_MAKE_ENV = $(QT5WEBENGINE_ENV)

I'm not really thrilled by this, and we had to do the same in
qt5webkit. This is modeled after the autotools-package infrastructure,
where normally environment variables passed to the ./configure script
don't need to be passed again at build time.

But if with qmake they are needed at both configure time and build
time, then perhaps we should change to have a single <pkg>_ENV
variable, passed at both configure and build time.

Let's see how many packages need this, and we'll adjust later if needed.

Best regards,

Thomas
-- 
Thomas Petazzoni, CTO, Bootlin
Embedded Linux and Kernel engineering
https://bootlin.com


More information about the buildroot mailing list