[Buildroot] [pkg-luarocks 1/6] pkg-luarocks: remove LUAROCKS_RUN_ENV

Thomas Petazzoni thomas.petazzoni at bootlin.com
Fri Mar 20 21:40:05 UTC 2020


Hello François,

I am getting back to this series, trying to get it finally merged.

On Wed, 18 Sep 2019 20:18:18 +0200
François Perrad <francois.perrad at gadz.org> wrote:

> Le mer. 18 sept. 2019 à 09:31, Thomas Petazzoni <
> thomas.petazzoni at bootlin.com> a écrit :  
> 
> > On Wed, 18 Sep 2019 08:19:10 +0200
> > Francois Perrad <fperrad at gmail.com> wrote:
> >  
> > > Signed-off-by: Francois Perrad <francois.perrad at gadz.org>  
> >
> > This requires more details in the commit log. Why can you do this ?
> >
> >  
> just a preliminary step,
> could be squashed with the next commit 2/6

So, preliminary steps are good to have separately if possible. But you
still didn't explain how this patch works. How is it possible to simply
delete LUAROCKS_RUN_ENV ? The variables passed in LUAROCKS_RUN_ENV are
not needed ? If they are not needed, why do they exist in the first
place ?

We really need a better explanation.

Thanks!

Thomas
-- 
Thomas Petazzoni, CTO, Bootlin
Embedded Linux and Kernel engineering
https://bootlin.com


More information about the buildroot mailing list