[Buildroot] [PATCH v1 1/3] package/liboping: add patch to fix gcc-8/gcc-9 snprintf truncation compile failure
Thomas Petazzoni
thomas.petazzoni at bootlin.com
Sat Mar 7 22:08:52 UTC 2020
Hello Peter,
On Fri, 6 Mar 2020 21:10:20 +0100
Peter Seiderer <ps.report at gmx.net> wrote:
> Add patch from upstream merge request ([1]) to fix fix gcc-8/gcc-9 snprintf
> truncation related compile failure (-Wall/-Werror), reported on the
> mailing list ([2]).
>
> Fixes:
>
> liboping.c: In function ‘ping_set_ttl’:
> liboping.c:207:9: error: ‘%s’ directive output may be truncated writing up to 255 bytes into a region of size 242 [-Werror=format-truncation=]
> 207 | "%s: %s", function, message);
> | ^~
>
> [1] https://github.com/octo/liboping/pull/50
> [2] http://lists.busybox.net/pipermail/buildroot/2020-March/275861.html
>
> Reported-by: Maik Brenke <Maik.Brenke at continental-corporation.com>
> Signed-off-by: Peter Seiderer <ps.report at gmx.net>
This build issue has happened once in the autobuilders:
http://autobuild.buildroot.net/results/b12/b12d86388b495a96194e0bcbb5c19a4e35cbc53d/build-end.log
But liboping has been built successfully zillions of times:
http://autobuild.buildroot.net/index.php?symbols%5BBR2_PACKAGE_LIBOPING%5D=y
Why is it that we don't see this build failure ?
Also, this build failure was reported at
https://github.com/octo/liboping/issues/38, and the upstream developer
says it has been fixed by
https://github.com/octo/liboping/commit/18ca43507b351f339ff23062541ee8d58e813a53,
which is different from your patch.
Could you clarify this ?
Thomas
--
Thomas Petazzoni, CTO, Bootlin
Embedded Linux and Kernel engineering
https://bootlin.com
More information about the buildroot
mailing list