[Buildroot] [PATCH 1/2] package/freescale-imx: fix i.MX8MMini configuration

[Thomas Petazzoni]

Hello Gary,

On Thu, 26 Mar 2020 17:49:42 +0100
Gary Bisson <gary.bisson at boundarydevices.com> wrote:

> - Just like i.MX8MQ, i.MX8MMini is using Hantro VPU.
> - Platform name wasn't set for i.MX8Mini
>   -> now differencing IMX8MQ and IMX8MM for VPU package  
> 
> Signed-off-by: Gary Bisson <gary.bisson at boundarydevices.com>

So, I've applied, but I have one comment/concern below.

> diff --git a/package/freescale-imx/Config.in b/package/freescale-imx/Config.in
> index f42bb11a3c..0a5be9c75a 100644
> --- a/package/freescale-imx/Config.in
> +++ b/package/freescale-imx/Config.in
> @@ -66,7 +66,8 @@ config BR2_PACKAGE_FREESCALE_IMX_PLATFORM
>  	default "IMX6UL" if BR2_PACKAGE_FREESCALE_IMX_PLATFORM_IMX6UL
>  	default "IMX7" if BR2_PACKAGE_FREESCALE_IMX_PLATFORM_IMX7
>  	default "IMX8" if BR2_PACKAGE_FREESCALE_IMX_PLATFORM_IMX8
> -	default "IMX8" if BR2_PACKAGE_FREESCALE_IMX_PLATFORM_IMX8M
> +	default "IMX8MQ" if BR2_PACKAGE_FREESCALE_IMX_PLATFORM_IMX8M
> +	default "IMX8MM" if BR2_PACKAGE_FREESCALE_IMX_PLATFORM_IMX8MM

I am not sure about the usefulness of this
BR2_PACKAGE_FREESCALE_IMX_PLATFORM string, especially for i.MX8
platforms. Indeed, this string is only used by the imx-lib and imx-vpu
packages, and it seems that they are not relevant for i.MX8. So what is
the "reference" to know what is the correct string for i.MX8 platforms
? Does it really make sense to have this option in
package/freescale-imx/Config.in ? Should we have it instead in imx-lib
and imx-vpu instead ?

Thanks!

Thomas
-- 
Thomas Petazzoni, CTO, Bootlin
Embedded Linux and Kernel engineering
https://bootlin.com