[Buildroot] [PATCH v3] configs/nenopi_neo4: new updated defconfig

Thomas Petazzoni thomas.petazzoni at bootlin.com
Tue Mar 31 21:23:57 UTC 2020


Hello Marek,

On Tue, 31 Mar 2020 08:51:58 +0200
Marek Belisko <marek.belisko at open-nandra.com> wrote:

> This patch revert 8af7b11bd8a95bc41e4de46f727f3b0afde465a4 and
> add extra options to have build working
> 
> Updates:
> - enable BR2_TARGET_ARM_TRUSTED_FIRMWARE_NEEDS_ARM32_TOOLCHAIN
> - bump kernel to 5.4
> - increase default rootfs size to 70M
> 
> Signed-off-by: Marek Belisko <marek.belisko at open-nandra.com>

Thanks for this new version. I was about to apply, but found something
important to be improved: could you use the mainline U-Boot instead?
Most notably, this will allow you to use the idbloader.img target,
which provides a ready-to-use binary for the first stage bootloader,
which in turns allows to simplify the post-build script. See the
configs/roc_pc_rk3399_defconfig configuration for an example of another
platform using RK3399.

Other minor nits: you should update the DEVELOPERS file to add yourself
as a maintainer for this defconfig, and if possible update the
.gitlab-ci.yml file by running "make .gitlab-ci.yml".

Could you work on these improvements and send an updated version?

Thanks a lot!

Thomas
-- 
Thomas Petazzoni, CTO, Bootlin
Embedded Linux and Kernel engineering
https://bootlin.com



More information about the buildroot mailing list