[Buildroot] [PATCH 2/2] support/config-fragments: add RISC-V 64-bit uclibc autobuild config

[Mark Corbin]

On Saturday, 9 May 2020 11:07:58 BST Thomas Petazzoni wrote:
> On Fri,  8 May 2020 11:33:38 +0100
> 
> Mark Corbin <mark at dibsco.co.uk> wrote:
> > Now that RISC-V 64 bit can use uclibc, glibc and musl we can add
> > uclibc to the autobuild internal toolchain configurations by
> > removing the musl specific config file and adding a generic one.
> > 
> > Signed-off-by: Mark Corbin <mark at dibsco.co.uk>
> > ---
> > 
> >  ...v64-internal-musl.config => br-riscv64-full-internal.config} | 1 -
> >  support/config-fragments/autobuild/toolchain-configs.csv        | 2 +-
> >  2 files changed, 1 insertion(+), 2 deletions(-)
> >  rename
> >  support/config-fragments/autobuild/{br-riscv64-internal-musl.config =>
> >  br-riscv64-full-internal.config} (57%)> 
> > diff --git
> > a/support/config-fragments/autobuild/br-riscv64-internal-musl.config
> > b/support/config-fragments/autobuild/br-riscv64-full-internal.config
> > similarity index 57%
> > rename from
> > support/config-fragments/autobuild/br-riscv64-internal-musl.config rename
> > to support/config-fragments/autobuild/br-riscv64-full-internal.config
> > index 89e7afb276..c729eb55e9 100644
> > --- a/support/config-fragments/autobuild/br-riscv64-internal-musl.config
> > +++ b/support/config-fragments/autobuild/br-riscv64-full-internal.config
> > @@ -1,3 +1,2 @@
> > 
> >  BR2_riscv=y
> > 
> > -BR2_TOOLCHAIN_BUILDROOT_MUSL=y
> > 
> >  BR2_TOOLCHAIN_BUILDROOT_CXX=y
> 
> This one is not "generic": it will only build a uClibc toolchain. It
> seems like you believe that since this defconfig fragment doesn't
> mention the C library, it will test glibc, musl and uclibc, but that's
> not the case. We do not randomize the choice of the C library, and
> since uclibc is our default, this new defconfig file will only test
> uclibc.

Sorry, that was my misinterpretation of 'full' when looking at config fragments 
for other architectures.

What would be preferred here? Should I leave the musl config as it is and add 
an additional fragment for uclibc?

Thanks

Mark