[Buildroot] [PATCH] package/nodejs: expose capability to compile host library

Linus linus at cosmos-ink.net
Sun May 17 22:34:05 UTC 2020


Hi Yann,

Thank you for your feedback.

> Please use git send-email to send patches; the way you sent this new
> iteration is not a proper patch, and did not get picked up by patchwork:
>     https://patchwork.ozlabs.org/project/buildroot/list/
I had hoped that I could provide the patch as well as the answer in one
email.
I had hoped that retaining the format of the patch as generated by git
would not be a problem.
I'll send the fixed patch in the next mail.

> You used 4 spaces here, when Peter explicitly stated that TABs should be
> used. Run "make check-pacakge" to check for these kind of issues.
See previous answer. Due to me copying it from the terminal into my email
client the terminal converted the tabs to spaces which I didn't notice.

> Also, those three options, BR_PACKAGE_HOST_LIBOPENSSL, BR_PACKAGE_HOST_ZLIB,
> and BR_PACKAGE_HOST_PYTHON, do not exist. For host packages, the options
> do not exist, unless they have to be visible in the menuconfig, which is
> not the case for those three.
I in fact, missed to check whether those exist. I had previously
noticed, that
when saving the config from make menuconfig, it would be checked whether
there
is an error in the select statement(s).
I assumed that, in case of failure, it would happen there, too. But I
have to
admit, that I didn't go out of the way to check it.

I removed the checks for host zlib and libopenssl and fixed the BR-Prefix
for host python (2).

Regards,
Linus Kaschulla

Am 17.05.20 um 21:48 schrieb Yann E. MORIN:
> Linux, All,
>
> On 2020-05-17 13:31 +0200, Linus spake thusly:
>> Hi Peter,
>>
>>> Indent should use tabs (instead of spaces)...
>> I'm sorry for that. I've overlooked that change (ported it
>> from the repository I'm working with).
>> I git fixuped it. The fixed patch is below.
> Please use git send-email to send patches; the way you sent this new
> iteration is not a proper patch, and did not get picked up by patchwork:
>     https://patchwork.ozlabs.org/project/buildroot/list/
>
> Besides, there are still issues, see below...
>
> [--SNIP--]
>> diff --git a/package/nodejs/Config.in.host b/package/nodejs/Config.in.host
>> new file mode 100644
>> index 0000000000..2169762b1b
>> --- /dev/null
>> +++ b/package/nodejs/Config.in.host
>> @@ -0,0 +1,5 @@
>> +config BR2_PACKAGE_HOST_NODEJS
>> +    bool "host nodejs"
>> +    select BR_PACKAGE_HOST_LIBOPENSSL
>> +    select BR_PACKAGE_HOST_PYTHON
>> +    select BR_PACKAGE_HOST_ZLIB
> You used 4 spaces here, when Peter explicitly stated that TABs should be
> used. Run "make check-pacakge" to check for these kind of issues.
>
> Also, those three options, BR_PACKAGE_HOST_LIBOPENSSL, BR_PACKAGE_HOST_ZLIB,
> and BR_PACKAGE_HOST_PYTHON, do not exist. For host packages, the options
> do not exist, unless they have to be visible in the menuconfig, which is
> not the case for those three.
>
> Regards,
> Yann E. MORIN.
>

-------------- next part --------------
A non-text attachment was scrubbed...
Name: signature.asc
Type: application/pgp-signature
Size: 833 bytes
Desc: OpenPGP digital signature
URL: <http://lists.busybox.net/pipermail/buildroot/attachments/20200518/53404ae0/attachment-0002.asc>


More information about the buildroot mailing list