[Buildroot] [PATCH 1/1] package/linuxptp: remove hardcoded interface from config to args

Thomas Petazzoni thomas.petazzoni at bootlin.com
Thu May 21 13:36:19 UTC 2020


Hello Heiko,

On Wed, 20 May 2020 07:16:48 +0200
Heiko Thiery <heiko.thiery at gmail.com> wrote:

> Interface configuration is hard coded in the config file. This will
> throw an error when this interace (eth0) is not present.
> 
> This patch removes the interface to be used from the config and appends it
> to the PTP4L_ARGS. With this the custom arguments can be set via
> /etc/defaults/ptp4l.

Well, you can also just as well provide your custom linuxptp.cfg in a
rootfs overlay, no?

Also, your change to linuxptp.cfg kind of breaks what is explained in
linuxptp.cfg:

# By default synchronize time in slave-only mode using UDP and hardware time
# stamps on eth0. If the difference to master is >1.0 second correct by
# stepping the clock instead of adjusting the frequency.

Thomas
-- 
Thomas Petazzoni, CTO, Bootlin
Embedded Linux and Kernel engineering
https://bootlin.com



More information about the buildroot mailing list