[Buildroot] [PATCH 1/1] package/linuxptp: remove hardcoded interface from config to args

Heiko Thiery heiko.thiery at gmail.com
Thu May 21 20:52:07 UTC 2020


Hi Thomas,


> > Interface configuration is hard coded in the config file. This will
> > throw an error when this interace (eth0) is not present.
> >
> > This patch removes the interface to be used from the config and appends it
> > to the PTP4L_ARGS. With this the custom arguments can be set via
> > /etc/defaults/ptp4l.
>
> Well, you can also just as well provide your custom linuxptp.cfg in a
> rootfs overlay, no?
>

Yes this is for sure a valid solution. You mean it doesn't matter
adding a custom linuxptp.cfg or a /etc/defaults/ptp4l to change the
interface to be used because both ways need to add a file to the
rootfs overlay?

> Also, your change to linuxptp.cfg kind of breaks what is explained in
> linuxptp.cfg:
>

I think it does not break the functionality. The patch only changes
the location of the interface to be used. ptp4l can set the interface
either in the config or in the arguments.


> # By default synchronize time in slave-only mode using UDP and hardware time
> # stamps on eth0. If the difference to master is >1.0 second correct by
> # stepping the clock instead of adjusting the frequency.

I read over the mention of the interface name eth0 in the comment.


-- 
Heiko



More information about the buildroot mailing list