[Buildroot] [PATCH 1/1] package/linuxptp: remove hardcoded interface from config to args

Heiko Thiery heiko.thiery at gmail.com
Mon May 25 09:10:01 UTC 2020


Hi Thomas,

Am Mo., 25. Mai 2020 um 09:40 Uhr schrieb Thomas Petazzoni
<thomas.petazzoni at bootlin.com>:
>
> Hello,
>
> On Thu, 21 May 2020 22:52:07 +0200
> Heiko Thiery <heiko.thiery at gmail.com> wrote:
>
> > > Well, you can also just as well provide your custom linuxptp.cfg in a
> > > rootfs overlay, no?
> >
> > Yes this is for sure a valid solution. You mean it doesn't matter
> > adding a custom linuxptp.cfg or a /etc/defaults/ptp4l to change the
> > interface to be used because both ways need to add a file to the
> > rootfs overlay?
>
> Exactly what I meant indeed.

Ok. But then the user needs to sync the config when changes are made
in the default of ptp4l/linuxptp unlike only changing the used
interface.

> > > Also, your change to linuxptp.cfg kind of breaks what is explained in
> > > linuxptp.cfg:
> >
> > I think it does not break the functionality. The patch only changes
> > the location of the interface to be used. ptp4l can set the interface
> > either in the config or in the arguments.
>
> No, it does not break the functionality, but the explanation in the
> comment becomes a bit weird, as the fact that eth0 is used is no longer
> configured through that config file.

When submitting a new patch version I will change the comment.

-- 
Heiko



More information about the buildroot mailing list