[Buildroot] [PATCH v2 2/2] package/systemd: add a menu entry to enable portable services

Gervais, Francois FGervais at distech-controls.com
Thu Nov 26 13:13:15 UTC 2020


Thank you.

Just a couple administrative questions:

Should I be the one to add your "reviewed-by" tag to the patch or is
it the person merging the patch that does it?

Do I increment the patch version doing so?


From: Norbert Lange <nolange79 at gmail.com>
Sent: November 26, 2020 5:44 AM
To: Gervais, Francois <FGervais at distech-controls.com>
Cc: buildroot <buildroot at buildroot.org>; Maxime Hadjinlian <maxime.hadjinlian at gmail.com>; Yann E . MORIN <yann.morin.1998 at free.fr>
Subject: Re: [PATCH v2 2/2] package/systemd: add a menu entry to enable portable services 
 
Am Mi., 25. Nov. 2020 um 23:41 Uhr schrieb Francois Gervais
<fgervais at distech-controls.com>:
>
> Signed-off-by: Francois Gervais <fgervais at distech-controls.com>
> ---
>  package/systemd/Config.in  | 17 +++++++++++++++++
>  package/systemd/systemd.mk |  6 ++++++
>  2 files changed, 23 insertions(+)
>
> diff --git a/package/systemd/Config.in b/package/systemd/Config.in
> index ec34478e3d..3966ba2fc7 100644
> --- a/package/systemd/Config.in
> +++ b/package/systemd/Config.in
> @@ -343,6 +343,23 @@ comment "polkit support needs a toolchain with C++, wchar, NPTL, gcc >= 4.9"
>                 !BR2_TOOLCHAIN_GCC_AT_LEAST_4_9 || \
>                 !BR2_USE_WCHAR
>
> +config BR2_PACKAGE_SYSTEMD_PORTABLED
> +       bool "enable portable services"
> +       help
> +         Portable services are systemd services that can be dynamically
> +         attached and detached from the system.
> +
> +         These services must come with their own root directory which
> +         they are bond to through an automatically generated drop-in.
> +
> +         They also have restrictions applied by the host system in the
> +         form of profiles.
> +
> +         This functionality is provided by the system service systemd-portabled
> +         along with the corresponding CLI portablectl.
> +
> +         https://urldefense.com/v3/__https://systemd.io/PORTABLE_SERVICES/__;!!Po4YltK3bPMkYw!gdRouwvVrT5d5xkLf7W05Cn-Qm6uCTRtCBu7CTwGU28zxW8UUnLDGHCr_nWk9nwXtJaP3wk$ 
> +
>  config BR2_PACKAGE_SYSTEMD_QUOTACHECK
>         bool "enable quotacheck tools"
>         help
> diff --git a/package/systemd/systemd.mk b/package/systemd/systemd.mk
> index e24c357ccf..5aed87f452 100644
> --- a/package/systemd/systemd.mk
> +++ b/package/systemd/systemd.mk
> @@ -416,6 +416,12 @@ else
>  SYSTEMD_CONF_OPTS += -Dpolkit=false
>  endif
>
> +ifeq ($(BR2_PACKAGE_SYSTEMD_PORTABLED),y)
> +SYSTEMD_CONF_OPTS += -Dportabled=true
> +else
> +SYSTEMD_CONF_OPTS += -Dportabled=false
> +endif
> +
>  ifeq ($(BR2_PACKAGE_SYSTEMD_NETWORKD),y)
>  SYSTEMD_CONF_OPTS += -Dnetworkd=true
>  SYSTEMD_NETWORKD_USER = systemd-network -1 systemd-network -1 * - - - systemd Network Management
> --
> 2.17.1
>

I would prefer this to be a single commit, no point in an extra "revert".
Other than that:

reviewed-by: Norbert Lange <nolange79 at gmail.com>

Norbert


More information about the buildroot mailing list