[Buildroot] [PATCH 1/2] defconfigs: use BR2_PACKAGE_HOST_UBOOT_TOOLS_BOOT_SCRIPT_

Arnout Vandecappelle arnout at mind.be
Thu Oct 8 07:06:36 UTC 2020



On 07/10/2020 21:30, Matthew Weber wrote:
> Arnout,
> 
> 
> On Wed, Oct 7, 2020 at 2:26 PM Arnout Vandecappelle <arnout at mind.be> wrote:
>>
>>
>>
>> On 07/10/2020 15:20, Matt Weber wrote:
>>> --- a/configs/bananapi_m1_defconfig
>>> +++ b/configs/bananapi_m1_defconfig
>>> @@ -21,8 +21,9 @@ BR2_TARGET_UBOOT_NEEDS_DTC=y
>>>  BR2_TARGET_UBOOT_NEEDS_PYLIBFDT=y
>>>  BR2_TARGET_UBOOT_SPL=y
>>>  BR2_TARGET_UBOOT_SPL_NAME="u-boot-sunxi-with-spl.bin"
>>> -BR2_TARGET_UBOOT_BOOT_SCRIPT=y
>>> -BR2_TARGET_UBOOT_BOOT_SCRIPT_SOURCE="board/bananapi/bananapi-m1/boot.cmd"
>>> +BR2_PACKAGE_HOST_UBOOT_TOOLS_BOOT_SCRIPT=y
>>> +BR2_PACKAGE_HOST_UBOOT_TOOLS_BOOT_SCRIPT_SOURCE="board/bananapi/bananapi-m1/boot.cmd"
>>>  BR2_PACKAGE_HOST_DOSFSTOOLS=y
>>>  BR2_PACKAGE_HOST_GENIMAGE=y
>>>  BR2_PACKAGE_HOST_MTOOLS=y
>>> +BR2_PACKAGE_HOST_UBOOT_TOOLS=y
>>
>>  Just appending it at the end is not so nice (especially for the defconfigs that
>> are manually formatted). So I've moved it to just before the existing location,
>> with a few exceptions. This is the addition to the commit message:
> 
> I noticed we weren't consistent with manual vs not.  What is the
> motivation for the manual formatting?

 The in-tree defconfigs are kind of documentation. Comments like "Linux headers
same as kernel, a 4.18 series" are useful.

 Regards,
 Arnout



More information about the buildroot mailing list