[Buildroot] [PATCH v3,2/2] package/zeek: new package

Fabrice Fontaine fontaine.fabrice at gmail.com
Mon Oct 26 22:50:22 UTC 2020


Hi Thomas,

Le lun. 26 oct. 2020 à 22:08, Thomas Petazzoni
<thomas.petazzoni at bootlin.com> a écrit :
>
> Hello Fabrice,
>
> On Sun, 25 Oct 2020 17:12:46 +0100
> Fabrice Fontaine <fontaine.fabrice at gmail.com> wrote:
>
> > +ZEEK_CONF_OPTS = \
> > +     -DBIFCL_EXE_PATH=$(HOST_DIR)/bin/bifcl \
> > +     -DBINPAC_EXE_PATH=$(HOST_DIR)/bin/binpac \
> > +     -DBROKER_DISABLE_DOCS=ON \
> > +     -DBROKER_DISABLE_TESTS=ON \
> > +     -DINSTALL_AUX_TOOLS=ON \
> > +     -DZEEK_ETC_INSTALL_DIR=/etc
> > +
> > +define ZEEK_FIX_PYTHON_PATH
> > +     $(SED) 's, at PYTHON_EXECUTABLE@,/usr/bin/python,' \
> > +             $(@D)/auxil/zeekctl/ZeekControl/ssh_runner.py
> > +endef
> > +
> > +ZEEK_POST_CONFIGURE_HOOKS += ZEEK_FIX_PYTHON_PATH
>
> Does this needs to be a post-configure hook ? Isn't that needed simply
> after the installation ?
I can't use @PYTHON_EXECUTABLE@ in a post install hook as cmake will
replace it with the expanded value of $(HOST_DIR)/bin/python.
I could replace $(HOST_DIR) by /usr in a post install hook but I find
this solution less elegant.
Another option would be to patch ssh_runner.py but I don't think that
upstream will accept that we hardcode /usr/bin/python.
>
> Thanks,
>
> Thomas
> --
> Thomas Petazzoni, CTO, Bootlin
> Embedded Linux and Kernel engineering
> https://bootlin.com
Best Regards,

Fabrice



More information about the buildroot mailing list