[Buildroot] [PATCH 1/3] package/libabseil-cpp: enforce C++11

Thomas Petazzoni thomas.petazzoni at bootlin.com
Thu Oct 29 22:36:00 UTC 2020


On Tue, 27 Oct 2020 18:40:44 +0100
Michael Nosthoff via buildroot <buildroot at busybox.net> wrote:

> From: Michael Nosthoff <buildroot at heine.tech>
> 
> For gcc < 6 the c++ default is 98. Abseil needs at least 11
> but doesn't enforce this anymore. So we need to do this.
> 
> Signed-off-by: Michael Nosthoff <buildroot at heine.tech>

Is this fixing a build issue? What was the thing that made you write
this patch?

> +# abseil needs c++ >= 11 but doesn't set this anymore,
> +# before gcc6 the default is 98.
> +ifeq ($(BR2_GCC_AT_LEAST_6_0),)
> +LIBABSEIL_CPP_CONF_OPTS += -DCMAKE_CXX_STANDARD=11
> +endif
> +
> +ifeq ($(BR2_HOST_GCC_AT_LEAST_6_0),)
> +HOST_LIBABSEIL_CPP_CONF_OPTS += -DCMAKE_CXX_STANDARD=11
> +endif

Can we do it unconditionally ?

Thanks,

Thomas
-- 
Thomas Petazzoni, CTO, Bootlin
Embedded Linux and Kernel engineering
https://bootlin.com



More information about the buildroot mailing list