[Buildroot] [PATCH v2 1/1] package/wpa_supplicant: fix wrong config

Nicolas Cavallari nicolas.cavallari at green-communications.fr
Fri Apr 2 09:08:03 UTC 2021


On 01/04/2021 03:43, Tian Yuanhao wrote:
> Hi Nicolas,
> 
> In my opinion, the two options CONFIG_CTRL_IFACE and 
> CONFIG_CTRL_IFACE_DBUS_NEW are not directly related except for their 
> similar names. It should be correct now. Could you please test it?

It works, you can add my Tested-By.

However, the maintainers will probably ask you to :
- Put the changelog below the "---" line, so that it does not appear in 
the commit message
- Maybe do one change at a time. The fix to disable CTRL_IFACE and the 
fix to disable CTRL_IFACE_DBUS_INTRO are two separate things that maybe 
should be in two patches.

> On 2021/3/17 上午11:37, Tian Yuanhao wrote:
>> When BR2_PACKAGE_WPA_SUPPLICANT_CTRL_IFACE is not set and
>> BR2_PACKAGE_WPA_SUPPLICANT_DBUS=y, CONFIG_CTRL_IFACE_DBUS_NEW will be
>> enabled by 's/^#\(CONFIG_CTRL_IFACE_DBUS_NEW\)/\1/' first, and then
>> disabled by 's/^\(CONFIG_CTRL_IFACE\)/#\1/'.
>>
>> v2:
>>    - fix it by adding '\>' after CONFIG_CTRL_IFACE
>>    - disable CONFIG_CTRL_IFACE_DBUS_INTRO when not enabled
>>
>> Signed-off-by: Tian Yuanhao <tianyuanhao at aliyun.com>
>> ---
>>   package/wpa_supplicant/wpa_supplicant.mk | 4 +++-
>>   1 file changed, 3 insertions(+), 1 deletion(-)
>>
>> diff --git a/package/wpa_supplicant/wpa_supplicant.mk 



More information about the buildroot mailing list