[Buildroot] [PATCH 1/1] package/tvheadend: add various options to disable optional components
Yann E. MORIN
yann.morin.1998 at free.fr
Sat Apr 3 12:22:19 UTC 2021
Bernd, All,
On 2021-04-03 11:49 +0200, Bernd Kuhls spake thusly:
> When enabled some IPTV streams are piped using /usr/bin/ffmpeg so make
> sure that the ffmpeg binary is present.
>
> Transcoding support can already be disabled reducing /usr/bin/tvheadend
> by 1,03MB.
>
> By disabling all new options provided by this patch the binary size can
> additionally be reduced by 2,08MB.
>
> Signed-off-by: Bernd Kuhls <bernd.kuhls at t-online.de>
> ---
[--SNIP--]
> +config BR2_PACKAGE_TVHEADEND_IPTV
> + bool "IPTV support"
> + default y
> + select BR2_PACKAGE_FFMPEG_FFMPEG if BR2_PACKAGE_FFMPEG
Here, ffmpeg is not mandatory, but see below...
> diff --git a/package/tvheadend/tvheadend.mk b/package/tvheadend/tvheadend.mk
> index 114142bfa9..f9e748531e 100644
> --- a/package/tvheadend/tvheadend.mk
> +++ b/package/tvheadend/tvheadend.mk
> @@ -63,6 +63,33 @@ TVHEADEND_CONF_OPTS += \
> --disable-libx265
> endif
>
> +ifeq ($(BR2_PACKAGE_TVHEADEND_DESCRAMBLER),y)
> +TVHEADEND_CONF_OPTS += --enable-cardclient --enable-cwc \
> + --enable-cccam --enable-capmt --enable-constcw
When a series of options does not fit on a single line, then only put
one option per line, please.
> +else
> +TVHEADEND_CONF_OPTS += --disable-cardclient --disable-cwc \
> + --disable-cccam --disable-capmt --disable-constcw
Ditto, of course.
> +endif
> +
> +ifeq ($(BR2_PACKAGE_TVHEADEND_IPTV),y)
> +TVHEADEND_CONF_OPTS += --enable-iptv
> +TVHEADEND_DEPENDENCIES += ffmpeg
Here, you are making ffmpeg mandatory, but nothing ensures it is
enabled...
So, if ffmpeg is mandatory, then we should make that explicit in
Config.in, e.g.:
config BR2_PACKAGE_TVHEADEND_IPTV
bool "iptv"
depends on BR2_PACKAGE_FFMPEG_ARCH_SUPPORTS
select BR2_PACKAGE_FFMPEG
select BR2_PACKAGE_FFMPEG_FFMPEG # runtime
defaut y
Also, since you are selecting BR2_PACKAGE_FFMPEG_FFMPEG, it means this
is a runtime dependency, right? Then is BR2_PACKAGE_FFMPEG itself needed
at all at build time?
Regards,
Yann E. MORIN.
> +else
> +TVHEADEND_CONF_OPTS += --disable-iptv
> +endif
> +
> +ifeq ($(BR2_PACKAGE_TVHEADEND_SATIP),y)
> +TVHEADEND_CONF_OPTS += --enable-satip_client --enable-satip_server
> +else
> +TVHEADEND_CONF_OPTS += --disable-satip_client --disable-satip_server
> +endif
> +
> +ifeq ($(BR2_PACKAGE_TVHEADEND_TIMESHIFT),y)
> +TVHEADEND_CONF_OPTS += --enable-timeshift
> +else
> +TVHEADEND_CONF_OPTS += --disable-timeshift
> +endif
> +
> ifeq ($(BR2_PACKAGE_LIBDVBCSA),y)
> TVHEADEND_DEPENDENCIES += libdvbcsa
> TVHEADEND_CONF_OPTS += --enable-tvhcsa
> --
> 2.29.2
>
> _______________________________________________
> buildroot mailing list
> buildroot at busybox.net
> http://lists.busybox.net/mailman/listinfo/buildroot
--
.-----------------.--------------------.------------------.--------------------.
| Yann E. MORIN | Real-Time Embedded | /"\ ASCII RIBBON | Erics' conspiracy: |
| +33 662 376 056 | Software Designer | \ / CAMPAIGN | ___ |
| +33 561 099 427 `------------.-------: X AGAINST | \e/ There is no |
| http://ymorin.is-a-geek.org/ | _/*\_ | / \ HTML MAIL | v conspiracy. |
'------------------------------^-------^------------------^--------------------'
More information about the buildroot
mailing list