[Buildroot] [git commit] utils/scanpypi: fix flake8 errors
Peter Korsgaard
peter at korsgaard.com
Fri Aug 6 20:13:56 UTC 2021
>>>>> "Arnout" == Arnout Vandecappelle (Essensium/Mind) <arnout at mind.be> writes:
> commit: https://git.buildroot.net/buildroot/commit/?id=f982f7043419dea2d21ebe20c1b383633a517674
> branch: https://git.buildroot.net/buildroot/commit/?id=refs/heads/master
> Commit e43c0509442c746bea305aa2b0a5f7ff5adfd142 introduced two flake8
> errors:
> utils/scanpypi:300:26: E231 missing whitespace after ','
> utils/scanpypi:302:9: F841 local variable 'setup' is assigned to but never used
> The first one is easily fixed. The second one needs a little bit of
> explanation. Before commit e43c0509, the return value of
> imp.load_module() was used to be able to explicitly call the 'setup'
> function in it in case the metadata was not populated. Since that
> commit, calling that function is no longer needed, since setup.py is
> executed in exactly the same way as when it's run from the command line,
> so if that doesn't work, it's completely broken anyway. Therefore, we
> can simply discard the return value of imp.load_module().
> Signed-off-by: Arnout Vandecappelle (Essensium/Mind) <arnout at mind.be>
Committed to 2021.02.x and 2021.05.x, thanks.
--
Bye, Peter Korsgaard
More information about the buildroot
mailing list