[Buildroot] [PATCH v3 1/2] package/lua-lunix: fix build with recent gcc

[Yann E. MORIN]

François, All,

On 2021-08-07 10:55 +0200, François Perrad spake thusly:
> Le jeu. 5 août 2021 à 19:05, Arnout Vandecappelle < [1]arnout at mind.be> a écrit :
[--SNIP--]
>    Unless this patch is accepted upstream (unlikely, given that there was no
>   maintainer activity on [1] since more than a month), a much better way IMHO is
>   to set it from the .mk file:
> 
>   LUA_LUNIX_BUILD_OPTS = CFLAGS="$(TARGET_CFLAGS) -DHAVE_SYS_SYSCTL_H=0"
> 
> It looks elegant but it doesn't work, because CFLAGS is already set in [6]pkg-luarocks.mk

I would argue that lua packages should have a way to provide their own
CFLAGS that would be able to override settng, probably something like:

    diff --git a/package/pkg-luarocks.mk b/package/pkg-luarocks.mk
    index fd79855878..4230783af0 100644
    --- a/package/pkg-luarocks.mk
    +++ b/package/pkg-luarocks.mk
    @@ -117,7 +117,7 @@ define $(2)_INSTALL_TARGET_CMDS
     			LUA_LIBDIR="$$(STAGING_DIR)/usr/lib" \
     			CC=$$(TARGET_CC) \
     			LD=$$(TARGET_CC) \
    -			CFLAGS="$$(LUAROCKS_CFLAGS)" \
    +			CFLAGS="$$(LUAROCKS_CFLAGS) $$($(2)_LUAROCKS_CFLAGS)" \
     			LIBFLAG="-shared $$(TARGET_LDFLAGS)" \
     			$$($(2)_BUILD_OPTS) $$($(2)_ROCKSPEC)
     endef

Could you please have a look into this?

Regards,
Yann E. MORIN.

> The file lunix-20170920-1.rockspec is not a part of the upstream project (
> [7]https://25thandclement.com/~william/projects/releases/lunix-20170920.tgz or [8]https://github.com/wahern/lunix).
> It was created by the author of Luarocks package, it is only available on [9]https://luarocks.org/modules/daurnimator/lunix
> So, my patch cannot be upstreamed, but it is currently the only way to do.
> 
> François
>  
> 
>   (This may not work though, depending on the order of the flags added by luarocks.)
> 
>    Regards,
>    Arnout
> 
>   > ++                                   
>   };
>   > ++                            };
>   > ++                    };
>   > ++            };
>   > +     };
>   > + }
>   > +--
>   > +2.30.2
>   > +
>   >
>   _______________________________________________
>   buildroot mailing list
>   [10]buildroot at busybox.net
>   [11]http://lists.busybox.net/mailman/listinfo/buildroot
> 
> Links:
> 1. mailto:arnout at mind.be
> 2. http://autobuild.buildroot.net/results/749a11d5289c6fec3b2f236b9073fc1ab730d090/
> 3. mailto:francois.perrad at gadz.org
> 4. mailto:francois.perrad at gadz.org
> 5. mailto:francois.perrad at gadz.org
> 6. http://pkg-luarocks.mk
> 7. https://25thandclement.com/~william/projects/releases/lunix-20170920.tgz
> 8. https://github.com/wahern/lunix
> 9. https://luarocks.org/modules/daurnimator/lunix
> 10. mailto:buildroot at busybox.net
> 11. http://lists.busybox.net/mailman/listinfo/buildroot

> _______________________________________________
> buildroot mailing list
> buildroot at busybox.net
> http://lists.busybox.net/mailman/listinfo/buildroot


-- 
.-----------------.--------------------.------------------.--------------------.
|  Yann E. MORIN  | Real-Time Embedded | /"\ ASCII RIBBON | Erics' conspiracy: |
| +33 662 376 056 | Software  Designer | \ / CAMPAIGN     |  ___               |
| +33 561 099 427 `------------.-------:  X  AGAINST      |  \e/  There is no  |
| http://ymorin.is-a-geek.org/ | _/*\_ | / \ HTML MAIL    |   v   conspiracy.  |
'------------------------------^-------^------------------^--------------------'