[Buildroot] [PATCH v2 1/3] package/libgeos: fix build failure due to missing -mcmodel=large

Giulio Benetti giulio.benetti at benettiengineering.com
Tue Aug 17 20:56:28 UTC 2021


Hi Arnout,

On 8/17/21 10:34 PM, Arnout Vandecappelle wrote:
> 
> 
> On 27/07/2021 00:34, Giulio Benetti wrote:
>> When building libgeos for or1k -mcmodel=large is needed to link, so let's
>> add that gcc option in case we're building for or1k.
>>
>> Signed-off-by: Giulio Benetti <giulio.benetti at benettiengineering.com>
>> ---
>>   package/libgeos/libgeos.mk | 4 ++++
>>   1 file changed, 4 insertions(+)
>>
>> diff --git a/package/libgeos/libgeos.mk b/package/libgeos/libgeos.mk
>> index a355732af8..43211d0434 100644
>> --- a/package/libgeos/libgeos.mk
>> +++ b/package/libgeos/libgeos.mk
>> @@ -23,6 +23,10 @@ ifeq ($(BR2_arm)$(BR2_armeb),y)
>>   LIBGEOS_CONF_OPTS += -DDISABLE_GEOS_INLINE=ON
>>   endif
>>   
>> +ifeq ($(BR2_or1k),y)
>> +LIBGEOS_CXXFLAGS += -mcmodel=large
> 
>   According to git, -mcmodel was added to GCC after the 11.2.0 release. Are you
> sure that this works?
> 
>   Oooh, we have a patch that adds it. But that patch is missing for 11.1.0 for
> some reason. Romain, you apparently didn't carry any of our patches when you
> added GCC 11 in 2ab88dac293aed5adf2504e8b182f9d8a306b935. The commit message
> doesn't say anything. Do you remember anything about the patches? The patch was
> added to master on May 21 and you only submitted the GCC bump on June 12, but
> perhaps you already had it lying around for a while?
> 
>   Giulio, maybe you can port the patch to 11.1.0?

You've read into my mind :-), I've sent it yesterday:
https://patchwork.ozlabs.org/project/buildroot/list/?series=258108

and that is valid for both libgeos and profobuf.

Best regards!
-- 
Giulio Benetti
Benetti Engineering sas

>   Regards,
>   Arnout
> 
>> +endif
>> +
>>   LIBGEOS_CONF_OPTS += -DCMAKE_CXX_FLAGS="$(LIBGEOS_CXXFLAGS)"
>>   
>>   $(eval $(cmake-package))
>>
> _______________________________________________
> buildroot mailing list
> buildroot at busybox.net
> http://lists.busybox.net/mailman/listinfo/buildroot
> 



More information about the buildroot mailing list