[Buildroot] [PATCH 2/3] configs/acmesystems_*: bump at91bootstrap3 version

Arnout Vandecappelle arnout at mind.be
Wed Aug 18 11:35:17 UTC 2021 


On 18/08/2021 13:20, Ludovic.Desroches at microchip.com wrote:
>>
>> On 16/08/2021 14:04, Ludovic Desroches via buildroot wrote:
>>> Signed-off-by: Ludovic Desroches <ludovic.desroches at microchip.com>
>>> ---
>>>   configs/acmesystems_acqua_a5_256mb_defconfig    | 2 +-
>>>   configs/acmesystems_acqua_a5_512mb_defconfig    | 2 +-
>>>   configs/acmesystems_aria_g25_128mb_defconfig    | 2 +-
>>>   configs/acmesystems_aria_g25_256mb_defconfig    | 2 +-
>>>   configs/acmesystems_arietta_g25_128mb_defconfig | 2 +-
>>>   configs/acmesystems_arietta_g25_256mb_defconfig | 2 +-
>>>   6 files changed, 6 insertions(+), 6 deletions(-)
>>>
>>> diff --git a/configs/acmesystems_acqua_a5_256mb_defconfig b/configs/acmesystems_acqua_a5_256mb_defconfig
>>> index 00b99c0ad8..f8129f3780 100644
>>> --- a/configs/acmesystems_acqua_a5_256mb_defconfig
>>> +++ b/configs/acmesystems_acqua_a5_256mb_defconfig
>>> @@ -19,7 +19,7 @@ BR2_TARGET_ROOTFS_EXT2_4=y
>>>   BR2_TARGET_AT91BOOTSTRAP3=y
>>>   BR2_TARGET_AT91BOOTSTRAP3_CUSTOM_GIT=y
>>>   BR2_TARGET_AT91BOOTSTRAP3_CUSTOM_REPO_URL="https://github.com/linux4sam/at91bootstrap.git"
>>> -BR2_TARGET_AT91BOOTSTRAP3_CUSTOM_REPO_VERSION="5232adb1c42636e1e9cf495a6abd1a8d66475f83"
>>> +BR2_TARGET_AT91BOOTSTRAP3_CUSTOM_REPO_VERSION="v3.10.3"
>>
>>   The point of having a fixed version is so that we are sure that it's only
>> updated after actually testin on a board. If you make such a wholesale change, I
>> assume you haven't actually tested it on all those boards... So you could just
>> as well have set BR2_TARGET_AT91BOOTSTRAP3_LATEST_VERSION_3X...
> 
> Right I didn't test it on old boards. I discussed with Eugen, the 
> maintainer of at91bootstrap, the need to release a 3.8.x and a 3.9.x or 
> not. 3.9 and 3.10 are about support for new boards so there is no 
> compatibility problem. Nevertheless, it's true that unless it it has 
> been tested we are not 100% sure...
> 
> If we set BR2_TARGET_AT91BOOTSTRAP3_LATEST_VERSION_3X, the risk is 
> higher as it becomes a continuous risk versus a one-shot risk.

 That's right.

> I have no strong opinion, so if there is a preference to set 
> BR2_TARGET_AT91BOOTSTRAP3_LATEST_VERSION_3X, I'll update the patches.

 That's not what I meant - what I meant is that mass changes like this are just
as bad as simply setting a non-fixed version. But as you say: it's a one-shot
case due to the build-time fix that is needed, so in that sense it's better than
setting it to latest version.

 Regards,
 Arnout


> 
> Regards,
> Ludovic
> 
> 
> 
>>
>>   That said, we really have to do this because all the defconfigs are broken at
>> the moment, so applied the series to master, thanks.
>>
>>   Regards,
>>   Arnout
>>
>>>   BR2_TARGET_AT91BOOTSTRAP3_DEFCONFIG="acqua-256m"
>>>   BR2_PACKAGE_HOST_DOSFSTOOLS=y
>>>   BR2_PACKAGE_HOST_GENIMAGE=y
>>> diff --git a/configs/acmesystems_acqua_a5_512mb_defconfig b/configs/acmesystems_acqua_a5_512mb_defconfig
>>> index f4af2501b8..e399d4a9ff 100644
>>> --- a/configs/acmesystems_acqua_a5_512mb_defconfig
>>> +++ b/configs/acmesystems_acqua_a5_512mb_defconfig
>>> @@ -19,7 +19,7 @@ BR2_TARGET_ROOTFS_EXT2_4=y
>>>   BR2_TARGET_AT91BOOTSTRAP3=y
>>>   BR2_TARGET_AT91BOOTSTRAP3_CUSTOM_GIT=y
>>>   BR2_TARGET_AT91BOOTSTRAP3_CUSTOM_REPO_URL="https://github.com/linux4sam/at91bootstrap.git"
>>> -BR2_TARGET_AT91BOOTSTRAP3_CUSTOM_REPO_VERSION="5232adb1c42636e1e9cf495a6abd1a8d66475f83"
>>> +BR2_TARGET_AT91BOOTSTRAP3_CUSTOM_REPO_VERSION="v3.10.3"
>>>   BR2_TARGET_AT91BOOTSTRAP3_DEFCONFIG="acqua-512m"
>>>   BR2_PACKAGE_HOST_DOSFSTOOLS=y
>>>   BR2_PACKAGE_HOST_GENIMAGE=y
>>> diff --git a/configs/acmesystems_aria_g25_128mb_defconfig b/configs/acmesystems_aria_g25_128mb_defconfig
>>> index cf62b5b72e..8bc8c4dcef 100644
>>> --- a/configs/acmesystems_aria_g25_128mb_defconfig
>>> +++ b/configs/acmesystems_aria_g25_128mb_defconfig
>>> @@ -29,7 +29,7 @@ BR2_TARGET_ROOTFS_EXT2_4=y
>>>   BR2_TARGET_AT91BOOTSTRAP3=y
>>>   BR2_TARGET_AT91BOOTSTRAP3_CUSTOM_GIT=y
>>>   BR2_TARGET_AT91BOOTSTRAP3_CUSTOM_REPO_URL="https://github.com/linux4sam/at91bootstrap.git"
>>> -BR2_TARGET_AT91BOOTSTRAP3_CUSTOM_REPO_VERSION="v3.8.13"
>>> +BR2_TARGET_AT91BOOTSTRAP3_CUSTOM_REPO_VERSION="v3.10.3"
>>>   BR2_TARGET_AT91BOOTSTRAP3_DEFCONFIG="aria-128m"
>>>
>>>   # Tools to build sdcard.img
>>> diff --git a/configs/acmesystems_aria_g25_256mb_defconfig b/configs/acmesystems_aria_g25_256mb_defconfig
>>> index 496ccd6853..d161b118ae 100644
>>> --- a/configs/acmesystems_aria_g25_256mb_defconfig
>>> +++ b/configs/acmesystems_aria_g25_256mb_defconfig
>>> @@ -29,7 +29,7 @@ BR2_TARGET_ROOTFS_EXT2_4=y
>>>   BR2_TARGET_AT91BOOTSTRAP3=y
>>>   BR2_TARGET_AT91BOOTSTRAP3_CUSTOM_GIT=y
>>>   BR2_TARGET_AT91BOOTSTRAP3_CUSTOM_REPO_URL="https://github.com/linux4sam/at91bootstrap.git"
>>> -BR2_TARGET_AT91BOOTSTRAP3_CUSTOM_REPO_VERSION="v3.8.13"
>>> +BR2_TARGET_AT91BOOTSTRAP3_CUSTOM_REPO_VERSION="v3.10.3"
>>>   BR2_TARGET_AT91BOOTSTRAP3_DEFCONFIG="aria-256m"
>>>
>>>   # Tools to build sdcard.img
>>> diff --git a/configs/acmesystems_arietta_g25_128mb_defconfig b/configs/acmesystems_arietta_g25_128mb_defconfig
>>> index 17ef7e757c..62bcbd44cb 100644
>>> --- a/configs/acmesystems_arietta_g25_128mb_defconfig
>>> +++ b/configs/acmesystems_arietta_g25_128mb_defconfig
>>> @@ -29,7 +29,7 @@ BR2_TARGET_ROOTFS_EXT2_4=y
>>>   BR2_TARGET_AT91BOOTSTRAP3=y
>>>   BR2_TARGET_AT91BOOTSTRAP3_CUSTOM_GIT=y
>>>   BR2_TARGET_AT91BOOTSTRAP3_CUSTOM_REPO_URL="https://github.com/linux4sam/at91bootstrap.git"
>>> -BR2_TARGET_AT91BOOTSTRAP3_CUSTOM_REPO_VERSION="v3.8.13"
>>> +BR2_TARGET_AT91BOOTSTRAP3_CUSTOM_REPO_VERSION="v3.10.3"
>>>   BR2_TARGET_AT91BOOTSTRAP3_DEFCONFIG="arietta-128m"
>>>
>>>   # Tools to build sdcard.img
>>> diff --git a/configs/acmesystems_arietta_g25_256mb_defconfig b/configs/acmesystems_arietta_g25_256mb_defconfig
>>> index aa0236bbb3..94258444a2 100644
>>> --- a/configs/acmesystems_arietta_g25_256mb_defconfig
>>> +++ b/configs/acmesystems_arietta_g25_256mb_defconfig
>>> @@ -29,7 +29,7 @@ BR2_TARGET_ROOTFS_EXT2_4=y
>>>   BR2_TARGET_AT91BOOTSTRAP3=y
>>>   BR2_TARGET_AT91BOOTSTRAP3_CUSTOM_GIT=y
>>>   BR2_TARGET_AT91BOOTSTRAP3_CUSTOM_REPO_URL="https://github.com/linux4sam/at91bootstrap.git"
>>> -BR2_TARGET_AT91BOOTSTRAP3_CUSTOM_REPO_VERSION="v3.8.13"
>>> +BR2_TARGET_AT91BOOTSTRAP3_CUSTOM_REPO_VERSION="v3.10.3"
>>>   BR2_TARGET_AT91BOOTSTRAP3_DEFCONFIG="arietta-256m"
>>>
>>>   # Tools to build sdcard.img
>>>
>

More information about the buildroot mailing list