[Buildroot] [PATCH] package/sentry-cli: remove package

[Adam Duskett]

Hey Thomas;

On Wed, Aug 18, 2021 at 2:54 PM Thomas Petazzoni
<thomas.petazzoni at bootlin.com> wrote:
>
> Hello Adam,
>
> On Wed, 18 Aug 2021 13:36:58 -0700
> Adam Duskett <aduskett at gmail.com> wrote:
>
> > It seems like version 1.68.0 fixes the build failures. I have tested
> > two different
> > defconfigs that are on the failure list:
> >   - bf7361dc482d8f3f97d523b7d56eabe5bc515ae8
> >   - 97aa03f497536462abc85011ba1c94874d18f237
> >
> > And the new version doesn't produce the failures that are plaguing the
> > autobuilders.
> >
> > Instead of removing the package, I would suggest updating it to 1.68.0 instead.
>
> Thanks for looking into this. Did you confirm that you were able to
> reproduce the failures *before* the version bump ?
>
Interestingly enough, my testing method was flawed. While I did spin
up a debian 9
docker container and the exact git hash that failed, I made the
mistake of running
`make host-sentry-cli` and not `make`

When calling host-sentry-cli directly, there isn't a failure, but when
running just `make`
the failure does appear. I am not sure how to pass include paths to
cargo, but it seems
like the only failure now is the missing zlib.h library if the package
is bumped to 1.68, as
the git repository error is indeed resolved.

Thanks!
Adam

> One of the issue seems to because by the host-sentry-cli calling into
> Git, which would probably work with in-tree builds, but not out-of-tree
> builds for example. Another issue seems to be related to zlib being
> available on the host system or not.
>
> So to know if the 1.68.0 update fixes the issue, we need to make sure
> that you were able to reproduce the failures with the current version,
> in the same setup as the one you tested the version bump with.
>
> Thanks!
>
> Thomas
> --
> Thomas Petazzoni, co-owner and CEO, Bootlin
> Embedded Linux and Kernel engineering
> https://bootlin.com