[Buildroot] [PATCH 1/1] package/nvidia-driver: fix build without X.org drivers

Vincent Fazio vfazio at xes-inc.com
Thu Aug 19 17:41:29 UTC 2021


Sorry about that. Apparently I did make those changes in our branch but 
forgot to fold them into a v2 for the submitted patch.

The only other change I'd recommend is moving the finalize hook inside 
the same block, since it doesn't apply if the X drivers aren't being 
included. More for logic's sake than anything.

Reviewed-by: Vincent Fazio <vfazio at xes-inc.com>

On 8/19/21 12:21 PM, Fabrice Fontaine wrote:
> Fix the following build failure without BR2_PACKAGE_NVIDIA_DRIVER_XORG
> raised since commit 9cda982855315d683d4880e6bb2a129133ea7213:
>
> ln: failed to create symbolic link '/tmp/instance-0/output-1/target/usr/lib/xorg/modules/extensions/libglx.so': No such file or directory
>
> Fixes:
>   - http://autobuild.buildroot.org/results/c2e7a826c105363309f70a3fcfe28bd53efcb94a
>
> Signed-off-by: Fabrice Fontaine <fontaine.fabrice at gmail.com>
> ---
>   package/nvidia-driver/nvidia-driver.mk | 12 ++++++------
>   1 file changed, 6 insertions(+), 6 deletions(-)
>
> diff --git a/package/nvidia-driver/nvidia-driver.mk b/package/nvidia-driver/nvidia-driver.mk
> index 7e89c1ab01..54c2aa46d8 100644
> --- a/package/nvidia-driver/nvidia-driver.mk
> +++ b/package/nvidia-driver/nvidia-driver.mk
> @@ -96,6 +96,12 @@ NVIDIA_DRIVER_LIBS += \
>   	nvidia_drv.so:xorg/modules/drivers/ \
>   	libglx.so.$(NVIDIA_DRIVER_VERSION):xorg/modules/extensions/
>   
> +# libglx needs a symlink according to the driver README. It has no SONAME
> +define NVIDIA_DRIVER_SYMLINK_LIBGLX
> +	ln -sf libglx.so.$(NVIDIA_DRIVER_VERSION) \
> +		$(TARGET_DIR)/usr/lib/xorg/modules/extensions/libglx.so
> +endef
> +
>   endif # X drivers
>   
>   ifeq ($(BR2_PACKAGE_NVIDIA_DRIVER_CUDA),y)
> @@ -187,12 +193,6 @@ define NVIDIA_DRIVER_INSTALL_STAGING_CMDS
>   	$(NVIDIA_DRIVER_INSTALL_GL_DEV)
>   endef
>   
> -# libglx needs a symlink according to the driver README. It has no SONAME
> -define NVIDIA_DRIVER_SYMLINK_LIBGLX
> -	ln -sf libglx.so.$(NVIDIA_DRIVER_VERSION) \
> -		$(TARGET_DIR)/usr/lib/xorg/modules/extensions/libglx.so
> -endef
> -
>   # For target, install libraries and X.org modules
>   define NVIDIA_DRIVER_INSTALL_TARGET_CMDS
>   	$(call NVIDIA_DRIVER_INSTALL_LIBS,$(TARGET_DIR))

-- 
Vincent Fazio
Embedded Software Engineer - ATS
Extreme Engineering Solutions, Inc
http://www.xes-inc.com

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.busybox.net/pipermail/buildroot/attachments/20210819/a13d6da3/attachment.html>


More information about the buildroot mailing list