[Buildroot] [PATCH] package/kvm-unit-tests: disable SSP

Thomas Petazzoni thomas.petazzoni at bootlin.com
Fri Aug 20 21:22:58 UTC 2021


Hello Matt,

On Fri, 20 Aug 2021 08:32:32 -0500
Matthew Weber via buildroot <buildroot at busybox.net> wrote:

> kvm-unit-tests shouldn't use stack-protector as the test suite is
> building free standing binaries to test QEMU. There is no guarantee
> that GCC has set a spec to filter out stack protector enabling with
> -ffreestanding so disabling explicitly to prevent a series of build
> failures.
> 
> Fixes:
> http://autobuild.buildroot.net/results/780/780c8c70ea7015113714cbd3841d96b08bd2f2aa/
> 
> Signed-off-by: Matthew Weber <matthew.weber at collins.com>
> ---
>  package/kvm-unit-tests/kvm-unit-tests.mk | 13 ++++++-------
>  1 file changed, 6 insertions(+), 7 deletions(-)

Thanks, but your patch doesn't apply to the master branch, and it makes
me think we're piling up work-arounds on work-arounds.

Indeed, the passing of -fno-stack-protector in EXTRA_CFLAGS has been
removed in master as of commit
d183146b5c7a1a8d1a3c828bd3b6d0660d97efc0, which itself says it is no
longer needed since commit 0788e921f961e36a50a94f8bb98f7eb75b312245.

However, it seems like despite
0788e921f961e36a50a94f8bb98f7eb75b312245, SSP is still being used.

Matt, Fabrice, could you review the situation and see what is the
correct fix moving forward ?

Thanks!

Thomas
-- 
Thomas Petazzoni, co-owner and CEO, Bootlin
Embedded Linux and Kernel engineering
https://bootlin.com


More information about the buildroot mailing list