[Buildroot] [PATCH] package/kvm-unit-tests: disable SSP

[Fabrice Fontaine]

Hello,

Le ven. 20 août 2021 à 23:23, Thomas Petazzoni
<thomas.petazzoni at bootlin.com> a écrit :
>
> Hello Matt,
>
> On Fri, 20 Aug 2021 08:32:32 -0500
> Matthew Weber via buildroot <buildroot at busybox.net> wrote:
>
> > kvm-unit-tests shouldn't use stack-protector as the test suite is
> > building free standing binaries to test QEMU. There is no guarantee
> > that GCC has set a spec to filter out stack protector enabling with
> > -ffreestanding so disabling explicitly to prevent a series of build
> > failures.
> >
> > Fixes:
> > http://autobuild.buildroot.net/results/780/780c8c70ea7015113714cbd3841d96b08bd2f2aa/
> >
> > Signed-off-by: Matthew Weber <matthew.weber at collins.com>
> > ---
> >  package/kvm-unit-tests/kvm-unit-tests.mk | 13 ++++++-------
> >  1 file changed, 6 insertions(+), 7 deletions(-)
>
> Thanks, but your patch doesn't apply to the master branch, and it makes
> me think we're piling up work-arounds on work-arounds.
>
> Indeed, the passing of -fno-stack-protector in EXTRA_CFLAGS has been
> removed in master as of commit
> d183146b5c7a1a8d1a3c828bd3b6d0660d97efc0, which itself says it is no
> longer needed since commit 0788e921f961e36a50a94f8bb98f7eb75b312245.
>
> However, it seems like despite
> 0788e921f961e36a50a94f8bb98f7eb75b312245, SSP is still being used.
>
> Matt, Fabrice, could you review the situation and see what is the
> correct fix moving forward ?
The link on the autobuilder failure is from February 2020 and I'm not
able to find a build failure due to SSP in the latest days so I assume
that this patch is not needed.
>
> Thanks!
>
> Thomas
> --
> Thomas Petazzoni, co-owner and CEO, Bootlin
> Embedded Linux and Kernel engineering
> https://bootlin.com
Best Regards,

Fabrice