[Buildroot] [PATCH] Config.in: disable Fortify Source for microblaze
Arnout Vandecappelle
arnout at mind.be
Mon Aug 23 21:09:10 UTC 2021
On 21/08/2021 00:53, Romain Naour wrote:
> As reported by Toolchain-builder project [1], the system doesn't
> boot when Fortify Source is enabled for glibc based toolchain
> (the init process hang).
>
> Also, hardening features may not be wanted or possible for such
> slow soft-core cpus [2].
>
> [1] https://gitlab.com/bootlin/toolchains-builder/-/jobs/1467624500
> [2] http://lists.busybox.net/pipermail/buildroot/2021-June/312416.html
>
> Signed-off-by: Romain Naour <romain.naour at gmail.com>
> Cc: Thomas Petazzoni <thomas.petazzoni at bootlin.com>
> Cc: Giulio Benetti <giulio.benetti at benettiengineering.com>
Applied to master, thanks. I reworded the commit message to avoid Giulio's
confusion.
Also, I added a dependency on BR2_FORTIFY_SOURCE_ARCH_SUPPORTS in the comment
that glibc and optimisation are needed.
Regards,
Arnout
> ---
> With BR2_RELRO_PARTIAL enabled, the system boot.
> ---
> Config.in | 7 +++++++
> 1 file changed, 7 insertions(+)
>
> diff --git a/Config.in b/Config.in
> index 2ef5d407e4..84f7fa6e8d 100644
> --- a/Config.in
> +++ b/Config.in
> @@ -853,9 +853,16 @@ endchoice
> comment "RELocation Read Only (RELRO) needs shared libraries"
> depends on !BR2_SHARED_LIBS
>
> +config BR2_FORTIFY_SOURCE_ARCH_SUPPORTS
> + bool
> + default y
> + # Microblaze glibc toolchains don't work with Fortify Source enabled
> + depends on !BR2_microblaze
> +
> choice
> bool "Buffer-overflow Detection (FORTIFY_SOURCE)"
> default BR2_FORTIFY_SOURCE_1
> + depends on BR2_FORTIFY_SOURCE_ARCH_SUPPORTS
> depends on BR2_TOOLCHAIN_USES_GLIBC
> depends on !BR2_OPTIMIZE_0
> help
>
More information about the buildroot
mailing list