[Buildroot] [PATCH v2 1/1] toolchain: handle toolchains with multiple ld*.so.* files

Jonah Petri jonah at petri.us
Thu Aug 26 13:24:25 UTC 2021


On 8/26/21 8:24 AM, Arnout Vandecappelle wrote:
>>>> +       if ! find -wholename $(STAGING_DIR)'/lib/ld*.so.*' > /dev/null; then \
>   With no path, find defaults to the current directory. However, STAGING_DIR is
> the full absolute directory, so wholename is never going to match it. It should
> probably be
>
> find $(STAGINGDIR) -wholename $(STAGINGDIR)/lib/ld*.so.*
>
>   In addition, however, find's exit code doesn't say anything about whether it
> was found or not. So we instead have to use the printed output and check if it's
> non-empty.
>
>   Finally, as an optimisation, we could use -quit to make sure it exits after the
> first match instead of needlessly continuing.
>
>
>   As Baruch said, however, this is too risky for master, so if a v3 comes it will
> be applied to next.


Hi Arnout & Baruch,

Thanks for the feedback, and I apologize for the breakage.  I'm 
embarrassed by my incorrect assumption about the return value of find 
(wow, I've been using that incorrectly for a lot of years!) and I 
understand and appreciate the rest of the comments above.

I'll wait for the next release to complete and then put in a v3.

Thanks for buildroot!

Jonah



More information about the buildroot mailing list