[Buildroot] [PATCH 1/2] package/mtd: change ubifs-utils depend to select

[Arnout Vandecappelle]

On 26/08/2021 08:10, Baruch Siach wrote:
> BR2_PACKAGE_MTD_UBIFS_UTILS is a blind option. The only way to enable it
> is to enable BR2_PACKAGE_MTD_MKFSUBIFS that selects it. ubihealthd
> dependency on BR2_PACKAGE_MTD_UBIFS_UTILS makes enabling it unintuitive.
> 
> Change depends to select.

 Actually, since upstream commit 5a6e813a6ba48c81889208bdbeff92b13958dd2d (which
is part of 2.1.3), I don't think this dependency is needed any more (it was a
hack due to an error in the upstream configure script, cfr. [1]). Could you give
that a spin (test with ubihealthd and nothing else) and simply remove the
dependency if it works?

 Regards,
 Arnout

[1] https://lore.kernel.org/buildroot/20210609234819.1860554-1-mmayer@broadcom.com/


> 
> Cc: Markus Mayer <mmayer at broadcom.com>
> Cc: Matt Weber <matthew.weber at collins.com>
> Signed-off-by: Baruch Siach <baruch at tkos.co.il>
> ---
>  package/mtd/Config.in | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
> 
> diff --git a/package/mtd/Config.in b/package/mtd/Config.in
> index abfe8066610c..1bd143d47e7d 100644
> --- a/package/mtd/Config.in
> +++ b/package/mtd/Config.in
> @@ -146,7 +146,7 @@ config BR2_PACKAGE_MTD_UBIFORMAT
>  config BR2_PACKAGE_MTD_UBIHEALTHD
>  	bool "ubihealthd"
>  	default y
> -	depends on BR2_PACKAGE_MTD_UBIFS_UTILS
> +	select BR2_PACKAGE_MTD_UBIFS_UTILS
>  
>  config BR2_PACKAGE_MTD_UBIMKVOL
>  	bool "ubimkvol"
>