[Buildroot] [PATCH] package/openblas: allow disabling multithreading
Thomas Petazzoni
thomas.petazzoni at bootlin.com
Sat Jan 2 16:34:37 UTC 2021
Hello Thomas,
On Wed, 2 Dec 2020 15:50:24 +0100
Thomas De Schampheleire <patrickdepinguin at gmail.com> wrote:
> +config BR2_PACKAGE_OPENBLAS_USE_THREAD
> + bool "use multithreading"
> + default y
> + depends on BR2_TOOLCHAIN_HAS_THREADS
> + depends on !BR2_STATIC_LIBS
> + help
> + Tell OpenBLAS to use multithreading, by passing USE_THREAD=1.
> +
> +config BR2_PACKAGE_OPENBLAS_USE_LOCKING
> + bool "use locking"
> + default y
> + depends on BR2_TOOLCHAIN_HAS_THREADS
Should this instead be:
depends on !BR2_PACKAGE_OPENBLAS_USE_THREAD
indeed, as you're explaining in the help text, when USE_THREAD=1, the
USE_LOCKING option has no effect, as it is forcefully enabled.
And perhaps drop the "default y" ?
Thanks,
Thomas
--
Thomas Petazzoni, CTO, Bootlin
Embedded Linux and Kernel engineering
https://bootlin.com
More information about the buildroot
mailing list