[Buildroot] [PATCHv2 1/2] package/zstd: build multithreaded library if supported

Thomas Petazzoni thomas.petazzoni at bootlin.com
Sat Jan 2 17:49:26 UTC 2021


Hello Thomas,

On Fri,  4 Dec 2020 10:57:01 +0100
Thomas De Schampheleire <patrickdepinguin at gmail.com> wrote:

> From: Thomas De Schampheleire <thomas.de_schampheleire at nokia.com>
> 
> libzstd.so is built without multi-threading support by default.
> The 'HAVE_THREAD' flag is not respected by lib/Makefile, only by
> programs/Makefile.
> 
> Use the %-mt recipe in lib/Makefile to enable multithreading.
> 
> Signed-off-by: Thomas De Schampheleire <thomas.de_schampheleire at nokia.com>

Your patch is fixing this for the target variant of zstd, but to me it
seems like the host variant also builds the library and programs
separately, so it is probably affected by the same issue, isn't it ?

Also, in your PATCH 2/2 you mention that zstd also supports cmake and
meson. Would switching to cmake-package or meson-package simplify a bit
this issue and generally what zstd.mk looks like ?

Thanks!

Thomas
-- 
Thomas Petazzoni, CTO, Bootlin
Embedded Linux and Kernel engineering
https://bootlin.com


More information about the buildroot mailing list