[Buildroot] [PATCH v4 1/8] package/freescale-imx/firmware-imx: Add option to install all ddr fw files

[Thomas Petazzoni]

Hello,

On Wed, 25 Nov 2020 19:30:10 +0100
Xavier Roumegue <xroumegue at gmail.com> wrote:

> Selecting this option will copy all ([lp]ddr4.bin) DDR training files to
> BINARIES_DIR.
> 
> Signed-off-by: Xavier Roumegue <xroumegue at gmail.com>

The commit log is very limited, but I think I figured out what's going
on: the upstream U-Boot script tools/imx8m_image.sh needs the "raw" DDR
firmware files provided by upstream firmware-imx, and not the already
"mungled" files generated by Buildroot firmware-imx.mk.

So overall, I think the right direction to take would be to make
firmware-imx.mk simply install the raw firmware files to
$(BINARIES_DIR). From there, we would have two paths:

 - For (old ?) NXP-specific U-Boot,
   board/freescale/common/imx/imx8-bootloader-prepare.sh would take
   care of doing the munging of those firmware files.

 - For upstream U-Boot, the munging of those firmware files is directly
   done by the U-Boot build system.

So, I'd like to see a first patch that makes firmware-imx.mk just
install the raw firmware files (either DDR4 or LPDDR4) to
$(BINARIES_DIR) and that changes
board/freescale/common/imx/imx8-bootloader-prepare.sh to do the munging
that was previously done by firmware-imx.mk.

With this, no need for this obscure
BR2_PACKAGE_FIRMWARE_IMX_DDR_FW_MULTIPLE option.

One question: firmware-imx has multiple "versions" of each firmware
file, for example:

-rw-r--r-- 1 thomas thomas  1668 16 nov.  10:10 lpddr4_pmu_train_1d_dmem_201904.bin
-rw-r--r-- 1 thomas thomas  1660 16 nov.  10:10 lpddr4_pmu_train_1d_dmem_202006.bin
-rw-r--r-- 1 thomas thomas  1668 16 nov.  10:10 lpddr4_pmu_train_1d_dmem.bin

Our current firmware-imx.mk uses the 201810 version for DDR4, but
upstream U-Boot uses the variant with no version in its name. Is it
important ?

Best regards,

Thomas
-- 
Thomas Petazzoni, CTO, Bootlin
Embedded Linux and Kernel engineering
https://bootlin.com