[Buildroot] [PATCH 1/1] package/wqy-zenhei: new package

Thomas Petazzoni thomas.petazzoni at bootlin.com
Mon Jan 4 20:18:27 UTC 2021


Hello Klaus,

On Mon, 4 Jan 2021 16:42:39 -0300
Klaus Heinrich Kiwi <klaus at linux.vnet.ibm.com> wrote:

> > Indeed for consistency reason, we try to only use the lower-case
> > package name as the short prompt for packags.  
> 
> I was puzzled by this comment so I looked at the commit and I think you
> meant to say that you removed the "(Free Chinese-capable fonts)" from the bool.
> That makes sense, thanks!

Gah, absolutely. I made a bogus copy/paste which made my whole
explanation confusing indeed, but it seems you understood what I meant
anyway :-)

> > Indicating the URL from which the tarball is downloaded and then the
> > hash calculated locally is not very useful. Also, SourceForge provides
> > md5 and sha1 hashes, and the hash of the license file was missing. So,
> > I've changed to:  
> 
> I understand the md5 and sha1 hashes that I completely missed, but couldn't decode why the locally computed/calculated
> sha256 is not useful.

The locally computed sha256 is useful. What was not is the comment:

# locally calculated from http://.....tar.gz

because it's obvious from where it has been calculated, so we tend to say just:

# locally calculated

or, if indeed there was another verification method:

# locally calculated, after checking the signature with ...

Does that make sense? But really, this is very tiny minor detail.

Thomas
-- 
Thomas Petazzoni, CTO, Bootlin
Embedded Linux and Kernel engineering
https://bootlin.com



More information about the buildroot mailing list