[Buildroot] [PATCH v2 1/1] package/casync: new package

Yair Ben-Avraham yairba at protonmail.com
Thu Jan 7 14:23:51 UTC 2021


Hi,

I tried without xz, build failed, details below:

./casync.config:
BR2_PACKAGE_ACL=y
BR2_PACKAGE_LIBCURL=y
BR2_PACKAGE_OPENSSL=y


./package/casync/casync.mk:
CASYNC_DEPENDENCIES = acl libcurl openssl
...
ifeq ($(BR2_PACKAGE_XZ),y)
CASYNC_DEPENDENCIES += xz
CASYNC_CONF_OPTS += -Dliblzma=enabled
else
CASYNC_CONF_OPTS += -Dliblzma=disabled
endif
...


br-arm-cortex-a9-glibc/logfile:
../src/castore.c:5:10: fatal error: lzma.h: No such file or directory
    5 | #include <lzma.h>
      |          ^~~~~~~~
compilation terminated.


In addition, in file ./src/castore.c , include <lzma.h> is not under if HAVE_LIBLZMA block, see counterexample inside ./src/compressor.h

So it's either adding xz to the dependencies or include <lzma.h> under if condition and try to build. What is better?

Yair
--
Yair Ben-Avraham
yairba at protonmail.com
+31.6.1316.5535

‐‐‐‐‐‐‐ Original Message ‐‐‐‐‐‐‐
On Thursday, January 7, 2021 11:13 AM, Thomas Petazzoni <thomas.petazzoni at bootlin.com> wrote:

> Hello,
>
> Thanks for the new iteration!
>
> On Thu, 07 Jan 2021 07:12:57 +0000
> Yair Ben-Avraham via buildroot buildroot at busybox.net wrote:
>
> > -   depends on BR2_PACKAGE_HAS_UDEV
>
> udev is not a mandatory dependency.
>
> > +CASYNC_VERSION = 4ad9bcb94bc83ff36cfc65515107ea06a88c2dfc
> > +CASYNC_SITE = $(call github,systemd,casync,$(CASYNC_VERSION))
> > +CASYNC_LICENSE = LGPL-2.1+
> > +CASYNC_LICENSE_FILES = LICENSE.LGPL2.1
> > +# xz is mandatory because of ./src/castore.c:5:10: #include <lzma.h>
> > +CASYNC_DEPENDENCIES = acl libcurl openssl xz
>
> This seems odd, Ithink I got it to build without xz. Did you pass
> the right -D option ?
>
> Other than those two questions, looks good to me!
>
> Thomas
>
> -----------------------------------------------------------------------------------------------------------------------------------------------------
>
> Thomas Petazzoni, CTO, Bootlin
> Embedded Linux and Kernel engineering
> https://bootlin.com





More information about the buildroot mailing list