[Buildroot] [PATCH 01/10 v3] core/pkg-infra: prepare for alternate default source archives

Vincent Fazio vfazio at xes-inc.com
Thu Jan 7 19:52:50 UTC 2021



On 12/29/20 5:01 AM, Yann E. MORIN wrote:
> The .tar.gz default extension is historical, and we initially used
> to only fetch tarballs from remote sites.
> 
> When we introduced downloads from VCS repositories, we kept that
> extension, and kept compressing with gz, by lack of good reason to
> switch to some other compression scheme.
> 
> However, nowadays, we will want to change the way we construct the
> tarballs we generate from VCS. This will de facto change the hashes
> of those tarballs.
> 
> So we will want that the archives we generate do not clash with the
> existing ones, so we need another filename. Thus, we need a way to
> be able to use a different extension when we generate archives from
> VCS.
> 
> Note that we do not need to play the host-defaults-to-target-value
> dance we do for the _SOURCE variable, because this is a purely internal
> variable, not exposed to packages, and as such, is not documented.
> 
> Signed-off-by: "Yann E. MORIN" <yann.morin.1998 at free.fr>
> Cc: Thomas Petazzoni <thomas.petazzoni at bootlin.com>
> Cc: Vincent Fazio <vfazio at xes-inc.com>
> ---
>   package/pkg-generic.mk | 3 ++-
>   1 file changed, 2 insertions(+), 1 deletion(-)
> 
> diff --git a/package/pkg-generic.mk b/package/pkg-generic.mk
> index 621fb91424..6a9389f1b5 100644
> --- a/package/pkg-generic.mk
> +++ b/package/pkg-generic.mk
> @@ -514,11 +514,12 @@ ifneq ($$($(2)_OVERRIDE_SRCDIR),)
>   $(2)_VERSION = custom
>   endif
>   
> +$(2)_SOURCE_EXT = .tar.gz
>   ifndef $(2)_SOURCE
>    ifdef $(3)_SOURCE
>     $(2)_SOURCE = $$($(3)_SOURCE)
>    else ifdef $(2)_VERSION
> -  $(2)_SOURCE			?= $$($(2)_BASENAME_RAW).tar.gz
> +  $(2)_SOURCE			?= $$($(2)_BASENAME_RAW)$$($(2)_SOURCE_EXT)
>    endif
>   endif
>   
> 

Reviewed-by: Vincent Fazio <vfazio at xes-inc.com>

-- 
Vincent Fazio
Embedded Software Engineer - Linux
Extreme Engineering Solutions, Inc
http://www.xes-inc.com



More information about the buildroot mailing list