[Buildroot] [PATCH 1/1] configs/bananapi_m1_plus_defconfig: new defconfig

Filip fskoneczny at gmail.com
Mon Jan 25 17:51:30 UTC 2021


Hi again Thomas. Corrected patch is now available:

	[v4] configs/bananapi_m1_plus_defconfig: new defconfig 

Let me know in case you've noticed anything else to fix.
Thanks again for guiding me through the first contribution :)

Filip

On 25.01.2021 08:51, Thomas Petazzoni wrote:
> Hello Filip,
> 
> On Sun, 24 Jan 2021 18:50:45 +0100
> Filip <fskoneczny at gmail.com> wrote:
> 
>>>> +BR2_TARGET_GENERIC_HOSTNAME="bananapi"
>>>> +BR2_TARGET_GENERIC_ISSUE="Welcome to Banana Pi!"
>>>> +BR2_ROOTFS_DEVICE_CREATION_DYNAMIC_MDEV=y  
>>>
>>> Is this needed for automatic loading of modules ?  
>>
>> Yes, it was loading brcmfmac automatically, I'm not sure though if this is desired in defconfig.
>> After comparing to other configs I decided to remove it and add "modprobe brcmfmac" to readme.txt in proper section instead.
>> Let me know if it's OK, or better to leave it to load automatically or something else.
> 
> I'd say let's keep mdev then, it's nice if the module gets loaded
> automatically.
> 
> Thanks!
> 
> Thomas
> 



More information about the buildroot mailing list