[Buildroot] [PATCH] boot/at91bootstrap3: updated to released 4.0.0 final version
Yann E. MORIN
yann.morin.1998 at free.fr
Sat Jul 31 07:11:29 UTC 2021
Thomas, Eugen, All,
On 2021-07-30 23:42 +0200, Thomas Petazzoni spake thusly:
> On Fri, 30 Jul 2021 13:39:08 +0300
> Eugen Hristev via buildroot <buildroot at busybox.net> wrote:
> > Update to AT91Bootstrap 4.0.0 version.
> > This package is now released under MIT license.
> > Signed-off-by: Eugen Hristev <eugen.hristev at microchip.com>
> > -AT91BOOTSTRAP3_LICENSE = Atmel License
> > +AT91BOOTSTRAP3_LICENSE = MIT
>
> While this change is correct for at91bootstrap 4.x, I don't think it's
> true for at91bootstrap 3.x, so I suppose this should instead be
> conditional?
>
> The problem is... what should be the condition? Indeed, testing on
> BR2_TARGET_AT91BOOTSTRAP3_LATEST_VERSION vs.
> BR2_TARGET_AT91BOOTSTRAP3_LATEST_VERSION_3X is not working, because the
> user can specify a custom Git or a custom tarball, and there we don't
> know what version is used (3.x of 4.x).
>
> I must admit I don't have a good idea here.
This is exactly what we do in the other packages in that situation: for
known versions, we define the appropriate licensing terms, and for
custom versions, we define nothing. See for example:
boot/barebox only license file is conditional
boot/uboot both licensing terms and license file are conditional
boot/optee-os only license file is conditional
linux only license file is conditional
And a few others I have forgotten.
So in this case, we'd hav something like:
ifeq ($(BR2_TARGET_AT91BOOTSTRAP3_LATEST_VERSION),y)
AT91BOOTSTRAP3_LICENSE = MIT
else ifeq ($(BR2_TARGET_AT91BOOTSTRAP3_LATEST_VERSION_3X),y)
AT91BOOTSTRAP3_LICENSE = Atmel License
endif
Regards,
Yann E. MORIN.
--
.-----------------.--------------------.------------------.--------------------.
| Yann E. MORIN | Real-Time Embedded | /"\ ASCII RIBBON | Erics' conspiracy: |
| +33 662 376 056 | Software Designer | \ / CAMPAIGN | ___ |
| +33 561 099 427 `------------.-------: X AGAINST | \e/ There is no |
| http://ymorin.is-a-geek.org/ | _/*\_ | / \ HTML MAIL | v conspiracy. |
'------------------------------^-------^------------------^--------------------'
More information about the buildroot
mailing list