[Buildroot] [PATCH v2 1/1] package/system-config-printer: new package

[Yann E. MORIN]

James, All,

On 2021-07-26 12:51 -0600, James Hilliard spake thusly:
> This package has some udev tools to assist with printer autodetection.
> 
> Signed-off-by: James Hilliard <james.hilliard1 at gmail.com>
> ---
> Changes v1 -> v2:
>   - update patch to merged upstream version
> ---
>  package/Config.in                             |  1 +
>  ...n-to-disable-xmlto-manual-generation.patch | 73 +++++++++++++++++++
>  package/system-config-printer/Config.in       |  7 ++
>  .../system-config-printer.hash                |  3 +
>  .../system-config-printer.mk                  | 32 ++++++++
>  5 files changed, 116 insertions(+)
>  create mode 100644 package/system-config-printer/0001-Add-option-to-disable-xmlto-manual-generation.patch
>  create mode 100644 package/system-config-printer/Config.in
>  create mode 100644 package/system-config-printer/system-config-printer.hash
>  create mode 100644 package/system-config-printer/system-config-printer.mk
> 
> diff --git a/package/Config.in b/package/Config.in
> index 12b1323fc2..2bd507c993 100644
> --- a/package/Config.in
> +++ b/package/Config.in
> @@ -2116,6 +2116,7 @@ menu "Networking applications"
>  	source "package/ctorrent/Config.in"
>  	source "package/cups/Config.in"
>  	source "package/cups-filters/Config.in"
> +	source "package/system-config-printer/Config.in"
>  	source "package/dante/Config.in"
>  	source "package/darkhttpd/Config.in"
>  	source "package/dehydrated/Config.in"
> diff --git a/package/system-config-printer/0001-Add-option-to-disable-xmlto-manual-generation.patch b/package/system-config-printer/0001-Add-option-to-disable-xmlto-manual-generation.patch
> new file mode 100644
> index 0000000000..e2cf395811
> --- /dev/null
> +++ b/package/system-config-printer/0001-Add-option-to-disable-xmlto-manual-generation.patch
> @@ -0,0 +1,73 @@
> +From 731c8d7e1f9edb527785d61f74031a5e5846554b Mon Sep 17 00:00:00 2001
> +From: James Hilliard <james.hilliard1 at gmail.com>
> +Date: Sun, 25 Jul 2021 16:30:59 -0600
> +Subject: [PATCH] Add option to disable xmlto manual generation.
> +
> +Signed-off-by: James Hilliard <james.hilliard1 at gmail.com>
> +[james.hilliard1 at gmail.com: backport from upstream commit
> +95e0b461f5a46c74b00287aca65732ea2fc9d69b]
> +---
> + Makefile.am  | 7 ++++++-
> + configure.ac | 5 +++++

This patch touches configure.ac and Makefile.am, so...

[--SNIP--]
> diff --git a/package/system-config-printer/system-config-printer.mk b/package/system-config-printer/system-config-printer.mk
> new file mode 100644
> index 0000000000..5a796515e3
> --- /dev/null
> +++ b/package/system-config-printer/system-config-printer.mk
> @@ -0,0 +1,32 @@
> +################################################################################
> +#
> +# system-config-printer
> +#
> +################################################################################
> +
> +SYSTEM_CONFIG_PRINTER_VERSION = 1.5.15
> +SYSTEM_CONFIG_PRINTER_SOURCE = system-config-printer-$(SYSTEM_CONFIG_PRINTER_VERSION).tar.xz
> +SYSTEM_CONFIG_PRINTER_SITE = https://github.com/OpenPrinting/system-config-printer/releases/download/v$(SYSTEM_CONFIG_PRINTER_VERSION)
> +SYSTEM_CONFIG_PRINTER_LICENSE = GPL-2.0
> +SYSTEM_CONFIG_PRINTER_LICENSE_FILES = COPYING
> +SYSTEM_CONFIG_PRINTER_DEPENDENCIES = cups

... you need: SYSTEM_CONFIG_PRINTER_AUTORECONF = YES

Otherwise, the autotools ,achinery will try to run autorconf on its
own, and may/will fail because it is goign to be using the host's
autoreconf et al., without the envirnement and options we need in the
Buildroot context.

Care to have a look and respin, please?

Regards,
Yann E. MORIN.

> +ifeq ($(BR2_PACKAGE_LIBGLIB2),y)
> +SYSTEM_CONFIG_PRINTER_DEPENDENCIES += libglib2
> +endif
> +
> +ifeq ($(BR2_PACKAGE_LIBGLIB2)$(BR2_PACKAGE_LIBUSB)$(BR2_PACKAGE_HAS_UDEV),yyy)
> +SYSTEM_CONFIG_PRINTER_CONF_OPTS = --with-udev-rules=yes
> +SYSTEM_CONFIG_PRINTER_DEPENDENCIES += libusb udev
> +else
> +SYSTEM_CONFIG_PRINTER_CONF_OPTS = --with-udev-rules=no
> +endif
> +
> +ifeq ($(BR2_PACKAGE_SYSTEMD),y)
> +SYSTEM_CONFIG_PRINTER_CONF_OPTS += --with-systemdsystemunitdir=/usr/lib/systemd/system
> +SYSTEM_CONFIG_PRINTER_DEPENDENCIES += systemd
> +else
> +SYSTEM_CONFIG_PRINTER_CONF_OPTS += --with-systemdsystemunitdir=no
> +endif
> +
> +$(eval $(autotools-package))
> -- 
> 2.25.1
> 
> _______________________________________________
> buildroot mailing list
> buildroot at busybox.net
> http://lists.busybox.net/mailman/listinfo/buildroot

-- 
.-----------------.--------------------.------------------.--------------------.
|  Yann E. MORIN  | Real-Time Embedded | /"\ ASCII RIBBON | Erics' conspiracy: |
| +33 662 376 056 | Software  Designer | \ / CAMPAIGN     |  ___               |
| +33 561 099 427 `------------.-------:  X  AGAINST      |  \e/  There is no  |
| http://ymorin.is-a-geek.org/ | _/*\_ | / \ HTML MAIL    |   v   conspiracy.  |
'------------------------------^-------^------------------^--------------------'