[Buildroot] [PATCH 2/2] package/lvm2: fix installation of systemd units
Arnout Vandecappelle
arnout at mind.be
Wed Jun 2 21:12:45 UTC 2021
On 21/05/2021 16:44, Yann E. MORIN wrote:
> Since we bump the version in commit 80997acd3587 (package/lvm2: bump
> version to 2.03.12), the installation of systemd units is no longer
> functional without a full installation.
>
> As Pascal puts it: the systemd service files don't make a whole lot of
> sense when there isn't a full lvm2 install.
>
> Move the conditional block that install system units, so that it only
> occurs when we do a full installation.
>
> Fixes;
In the future, please use a colon so patchwork picks it up as a fix :-)
> http://autobuild.buildroot.org/results/f47/f470ffb55625e2639cecde713442550eb532d0d7/
> http://autobuild.buildroot.org/results/954/9547929292e81671fbe3a5b4bbc87a6424edb1ca/
> http://autobuild.buildroot.org/results/303/30359c351a6ce2f9139494a531e036f0b0406ccf
>
> Signed-off-by: Yann E. MORIN <yann.morin.1998 at free.fr>
> Co-Developped-by: Pascal de Bruijn <p.debruijn at unilogic.nl>
> Cc: Pascal de Bruijn <p.debruijn at unilogic.nl>
> Cc: Fabrice Fontaine <fontaine.fabrice at gmail.com>
Series applied to master, thanks.
Regards,
Arnout
> ---
> package/lvm2/lvm2.mk | 7 +++----
> 1 file changed, 3 insertions(+), 4 deletions(-)
>
> diff --git a/package/lvm2/lvm2.mk b/package/lvm2/lvm2.mk
> index 00baa50a86..5ce79768b6 100644
> --- a/package/lvm2/lvm2.mk
> +++ b/package/lvm2/lvm2.mk
> @@ -49,16 +49,15 @@ endif
> ifeq ($(BR2_PACKAGE_LVM2_STANDARD_INSTALL),y)
> LVM2_INSTALL_STAGING_OPTS += install
> LVM2_INSTALL_TARGET_OPTS += install
> +ifeq ($(BR2_INIT_SYSTEMD),y)
> +LVM2_INSTALL_TARGET_OPTS += install_systemd_units install_systemd_generators
> +endif
> else
> LVM2_MAKE_OPTS = device-mapper
> LVM2_INSTALL_STAGING_OPTS += install_device-mapper
> LVM2_INSTALL_TARGET_OPTS += install_device-mapper
> endif
>
> -ifeq ($(BR2_INIT_SYSTEMD),y)
> -LVM2_INSTALL_TARGET_OPTS += install_systemd_units install_systemd_generators
> -endif
> -
> ifeq ($(BR2_TOOLCHAIN_SUPPORTS_PIE),)
> LVM2_CONF_ENV += ac_cv_flag_HAVE_PIE=no
> endif
>
More information about the buildroot
mailing list